Skip to content

refactor: update account item list selection element to fix flakiness #15206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

refactor: update account item list selection element to fix flakiness #15206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d104981
refactor: update getSelectWithMenuElement to getSelectWithMenuElement…
cmd-ob May 7, 2025
b79f334
Merge branch 'main' into fix/select-account-action-e2e
cmd-ob May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions e2e/pages/wallet/AccountListBottomSheet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,17 @@ class AccountListBottomSheet {
return Matchers.getElementByID(CellComponentSelectorsIDs.MULTISELECT, index);
}

getSelectWithMenuElement(index) {
/**
* Retrieves the title/name of an element using the `cellbase-avatar-title` ID.
* Note: The `select-with-menu` ID element seems to never receive the tap event,
* so this method fetches the title/name instead.
*
* @param {number} index - The index of the element to retrieve.
* @returns {Detox.IndexableNativeElement} The matcher for the element's title/name.
*/
getSelectWithMenuElementName(index) {
return Matchers.getElementByID(
CellComponentSelectorsIDs.SELECT_WITH_MENU,
CellComponentSelectorsIDs.BASE_TITLE,
index,
);
}
Expand All @@ -85,11 +93,11 @@ class AccountListBottomSheet {
}

async tapToSelectActiveAccountAtIndex(index) {
await Gestures.tap(this.getSelectWithMenuElement(index));
await Gestures.tap(this.getSelectWithMenuElementName(index));
}

async longPressAccountAtIndex(index) {
await Gestures.tapAndLongPress(this.getSelectWithMenuElement(index));
await Gestures.tapAndLongPress(this.getSelectWithMenuElementName(index));
}

async tapAddAccountButton() {
Expand Down
Loading