Skip to content

Conversation

@infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Jul 24, 2025

Description

This PR reenables Ledger hardware wallet support for Mobile Swaps/Bridges.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #17475
Patch based off of: https://github.com/MetaMask/core/compare/patch/bridge-status-controller-v34-mobile-hardware?expand=1

Manual testing steps

  1. Import a Ledger account
  2. Go to Swaps
  3. Swap native gas token
  4. Swap ERC20 with approval
  5. Txs should succeed

Screenshots/Recordings

Before

After

hw-wallet.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Jul 24, 2025
@infiniteflower infiniteflower added the QA Passed QA testing has been completed and passed label Jul 24, 2025
@sonarqubecloud
Copy link

@infiniteflower infiniteflower marked this pull request as ready for review July 24, 2025 19:03
@infiniteflower infiniteflower requested a review from a team as a code owner July 24, 2025 19:03
@infiniteflower infiniteflower requested a review from a team July 24, 2025 19:03
@infiniteflower infiniteflower changed the title Fix/swaps mobile hw tx fix: cp-7.52.0 swaps mobile hw tx Jul 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cafb4b4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6db7f640-a9e5-477a-b35a-d0ddd84a8839

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@infiniteflower infiniteflower added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit a80a3e9 Jul 24, 2025
56 of 58 checks passed
@infiniteflower infiniteflower deleted the fix/swaps-mobile-hw-tx branch July 24, 2025 21:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 24, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Unable to swap using hardware wallet

5 participants