test: E2e perps add funds #20936
Open
test: E2e perps add funds #20936
+1,955
−192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
racitores
force-pushed
the
e2e-perps-add-funds
branch
from
b104891 to
b0745fc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
racitores
added
the
no-changelog
christopherferreira9
requested changes
Oct 8, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
racitores
force-pushed
the
e2e-perps-add-funds
branch
from
869e8c2 to
705146c
Compare
gambinish
previously approved these changes
Oct 8, 2025
racitores
dismissed stale reviews from christopherferreira9 and gambinish
via
eea1afb
racitores
force-pushed
the
e2e-perps-add-funds
branch
2 times, most recently
from
eeb42d8 to
5e3fffb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20936 +/- ##
==========================================
+ Coverage 77.11% 77.24% +0.13%
==========================================
Files 3615 3642 +27
Lines 89144 89531 +387
Branches 16861 16956 +95
==========================================
+ Hits 68745 69160 +415
+ Misses 15721 15698 -23
+ Partials 4678 4673 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jvbriones
previously approved these changes
Oct 21, 2025
racitores
force-pushed
the
e2e-perps-add-funds
branch
2 times, most recently
from
b6ccbdf to
2feb60d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
racitores
force-pushed
the
e2e-perps-add-funds
branch
from
1f0e273 to
a0eec33
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
racitores
force-pushed
the
e2e-perps-add-funds
branch
from
c48135b to
89b03b8
Compare
…ead of deeplinks (#21668) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR refactors e2eBridgePerps to use the CommandQueueServer polling instead of deeplinks. All references to deeplinks in this context were kept. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Switches Perps E2E control from deeplinks to an HTTP-polled CommandQueueServer queue and updates helpers/specs to enqueue commands. > > - **E2E Bridge (Perps)**: > - Add HTTP polling with axios to read commands from `http://<host>:<port>/queue.json` (and `/debug.json`) and apply `push-price`, `force-liquidation`, and `mock-deposit` via the Perps mock service. > - Start polling during `autoConfigureE2EBridge`; retain lightweight deeplink handler as fallback. > - **E2E Framework**: > - `e2e/framework/fixtures/CommandQueueServer.ts`: export `CommandQueueItem`; add `GET /debug.json` (non-destructive) alongside existing `GET /queue.json` (clears queue). > - **Test Helpers**: > - `e2e/specs/perps/helpers/perps-modifiers.ts`: add server-backed methods (`updateMarketPriceServer`, `triggerLiquidationServer`, `applyDepositUSDServer`) that enqueue `PerpsModifiersCommandTypes`; keep deeplink methods. > - **Specs**: > - `e2e/specs/perps/perps-add-funds.spec.ts`: use `TestSuiteParams.commandQueueServer` and switch deposit mock to `applyDepositUSDServer`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9e3a527. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
racitores
force-pushed
the
e2e-perps-add-funds
branch
from
89b03b8 to
820d3aa
Compare
|
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR is splitting the content of another much bigger [PR](#20936) to simplify the review and merge I'll be adding add funds in perps <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds Perps E2E smoke tests and infrastructure (HTTP command-queue bridge, mocks, Sentry module aliasing) and runs them on iOS/Android CI. > > - **E2E Perps Infrastructure**: > - Add HTTP command-queue polling in `app/components/UI/Perps/utils/e2eBridgePerps.ts` with deep link handler refinements, mock deposit, and duplicate-link protection. > - Introduce command queue server (`e2e/framework/fixtures/CommandQueueServer.ts`) and plumb ports via `app/util/test/utils.js`, `shim.js`, Detox reverse ports, and fixture lifecycle. > - Expand Perps controller mixin (`e2e/controller-mocking/mock-config/perps-controller-mixin.ts`) with overrides for orders, fills, funding, cancel order, TP/SL updates, deterministic liquidation price, and provider wrapping. > - Enhance Perps mock service (`e2e/.../perps-e2e-mocks.ts`) with deposits, close fills, orders history, TP/SL trigger orders, price/liq handling, and seeded data. > - Add Arbitrum RPC and API mocks (`e2e/api-mocking/perps-arbitrum-mocks.ts`). > - **New Tests & Page Objects**: > - Add Perps “Add funds” smoke spec (`e2e/specs/perps/perps-add-funds.spec.ts`) and helpers/pages (`PerpsDepositView`, `PerpsDepositProcessingView`, updates to `PerpsTabView`, `TabBarComponent`, `Matchers`). > - Update deep link mapping to `metamask://e2e/perps/` (`e2e/framework/DeepLink.ts`) and add server-driven modifiers. > - **CI**: > - Add `perps-android-smoke` and `perps-ios-smoke` jobs and include them in report steps. > - **Module Aliasing**: > - Alias Sentry packages to E2E no-op mocks via `metro.config.js`; add mock files under `e2e/module-mocking/sentry/`. > - **Config/Quality**: > - Exclude `e2eBridgePerps.ts` from Sonar analysis; add docs (`e2e/docs/*`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit c904dce. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
salimtb
pushed a commit
that referenced
this pull request
Nov 4, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR is splitting the content of another much bigger [PR](#20936) to simplify the review and merge I'll be adding add funds in perps <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds Perps E2E smoke tests and infrastructure (HTTP command-queue bridge, mocks, Sentry module aliasing) and runs them on iOS/Android CI. > > - **E2E Perps Infrastructure**: > - Add HTTP command-queue polling in `app/components/UI/Perps/utils/e2eBridgePerps.ts` with deep link handler refinements, mock deposit, and duplicate-link protection. > - Introduce command queue server (`e2e/framework/fixtures/CommandQueueServer.ts`) and plumb ports via `app/util/test/utils.js`, `shim.js`, Detox reverse ports, and fixture lifecycle. > - Expand Perps controller mixin (`e2e/controller-mocking/mock-config/perps-controller-mixin.ts`) with overrides for orders, fills, funding, cancel order, TP/SL updates, deterministic liquidation price, and provider wrapping. > - Enhance Perps mock service (`e2e/.../perps-e2e-mocks.ts`) with deposits, close fills, orders history, TP/SL trigger orders, price/liq handling, and seeded data. > - Add Arbitrum RPC and API mocks (`e2e/api-mocking/perps-arbitrum-mocks.ts`). > - **New Tests & Page Objects**: > - Add Perps “Add funds” smoke spec (`e2e/specs/perps/perps-add-funds.spec.ts`) and helpers/pages (`PerpsDepositView`, `PerpsDepositProcessingView`, updates to `PerpsTabView`, `TabBarComponent`, `Matchers`). > - Update deep link mapping to `metamask://e2e/perps/` (`e2e/framework/DeepLink.ts`) and add server-driven modifiers. > - **CI**: > - Add `perps-android-smoke` and `perps-ios-smoke` jobs and include them in report steps. > - **Module Aliasing**: > - Alias Sentry packages to E2E no-op mocks via `metro.config.js`; add mock files under `e2e/module-mocking/sentry/`. > - **Config/Quality**: > - Exclude `e2eBridgePerps.ts` from Sonar analysis; add docs (`e2e/docs/*`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit c904dce. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
perps-add-funds.mp4
limit-long-fill.mp4
limit-long-fill.mp4
perps-position-liquidation.mp4
perps-activity-transactions.mp4
This one goes to regression pipeline:
https://github.com/user-attachments/assets/8fc94d92-8e6c-4208-a3e6-eb6fcb80946d
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds robust Perps E2E flows (add funds, activity, limit orders, liquidation) backed by a new HTTP command queue/polling bridge, expanded mocks, minor UI testID hooks, and splits SmokeTrade in CI.
/queue.json,/debug.json) with app-side polling (e2eBridgePerps.ts) and deeplink handling cleanup; ports wired viautils.jsandshim.js(XHR proxy bypass for localhost).metamask://uniformly.Written by Cursor Bugbot for commit 820d3aa. This will update automatically on new commits. Configure here.