-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: Implement short living ens resolver for Name component after send flow
#21515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+276
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @OGPoyraz : is it possible that we save the resolution as metadata in transaction, that will be better than caching resolution result ? |
|
vinistevam
reviewed
Nov 3, 2025
|
|
||
| if (resolvedAddress && isEvmSendType) { | ||
| // Set short living cache of ENS resolution for the given chain and address for confirmation screen | ||
| setResolvedAddress(chainId, to, resolvedAddress); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
vinistevam
approved these changes
Nov 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-7.59.0
Issue or pull request that will be included in release 7.59.0
size-M
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Similarly what's being done in MetaMask/metamask-extension#37047 this PR implements a short living cache for
Namecomponent to use after send flow.Changelog
CHANGELOG entry: Show ENS name in the confirmation after picking ENS recipient in send flow
Related issues
Fixes: #19072
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-10-22.at.13.18.00.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a 5‑minute ENS resolution cache used post-send and surfaces cached ENS in Name display; integrates with validation and updates tests.
useSendFlowEnsResolutionswithsetResolvedAddressandgetResolvedENSNameto cache ENS perchainId:address.useNameValidationto callsetResolvedAddress(chainId, ensName, resolvedAddress)whenisEvmSendTypeand ENS resolves.useDisplayNameto readensNameviagetResolvedENSName(variation, value)and prioritize it innameselection.useNameValidationtests to assert cache writes only for EVM/ENS.useDisplayNametest to verify ENS name is returned.Written by Cursor Bugbot for commit c5a24a9. This will update automatically on new commits. Configure here.