-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(ds): accept listItemProps in ListItemSelect #22277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
georgewrmarshall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! LGTM!
|



Description
This pull request enhances the flexibility of the
ListItemSelectcomponent by allowing custom props to be passed directly to its nestedListItemcomponent. This makes it easier to customize accessibility and other properties when usingListItemSelect.Component extensibility improvements:
listItemPropsprop to theListItemSelectPropsinterface, allowing consumers to pass custom props to the nestedListItemcomponent.ListItemSelectcomponent implementation to spreadlistItemPropsonto the nestedListItemelement. [1] [2]Testing enhancements:
listItemPropsare correctly passed through to the nestedListItem, ensuring that properties likeaccessibilityHintare set as expected.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
N/A
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds
listItemPropstoListItemSelectto forward props to its nestedListItem, with a test verifying passthrough (e.g., accessibility hints).ListItemSelect:listItemPropstoListItemSelectPropsand spreads onto nestedListIteminListItemSelect.tsx.listItemProps(e.g.,accessibilityHint,testID) are passed through to the nestedListItem.Written by Cursor Bugbot for commit 5e7b8bf. This will update automatically on new commits. Configure here.