Skip to content

Conversation

@wachunei
Copy link
Member

@wachunei wachunei commented Nov 6, 2025

Description

This pull request enhances the flexibility of the ListItemSelect component by allowing custom props to be passed directly to its nested ListItem component. This makes it easier to customize accessibility and other properties when using ListItemSelect.

Component extensibility improvements:

  • Added a new optional listItemProps prop to the ListItemSelectProps interface, allowing consumers to pass custom props to the nested ListItem component.
  • Updated the ListItemSelect component implementation to spread listItemProps onto the nested ListItem element. [1] [2]

Testing enhancements:

  • Added a test to verify that custom listItemProps are correctly passed through to the nested ListItem, ensuring that properties like accessibilityHint are set as expected.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds listItemProps to ListItemSelect to forward props to its nested ListItem, with a test verifying passthrough (e.g., accessibility hints).

  • Component Library
    • ListItemSelect:
      • Adds optional listItemProps to ListItemSelectProps and spreads onto nested ListItem in ListItemSelect.tsx.
    • Tests:
      • Adds test ensuring listItemProps (e.g., accessibilityHint, testID) are passed through to the nested ListItem.

Written by Cursor Bugbot for commit 5e7b8bf. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Nov 6, 2025
@wachunei wachunei marked this pull request as ready for review November 6, 2025 19:54
@wachunei wachunei requested a review from a team as a code owner November 6, 2025 19:54
@wachunei wachunei added team-design-system All issues relating to design system in Mobile and removed team-ramp issues related to Ramp features labels Nov 6, 2025
@github-actions github-actions bot added the size-S label Nov 6, 2025
@wachunei
Copy link
Member Author

wachunei commented Nov 6, 2025

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! LGTM!

@wachunei wachunei mentioned this pull request Nov 6, 2025
7 tasks
@wachunei wachunei enabled auto-merge November 7, 2025 11:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

@wachunei wachunei added this pull request to the merge queue Nov 7, 2025
Merged via the queue into main with commit 327cf31 Nov 7, 2025
85 checks passed
@wachunei wachunei deleted the feat/list-item-select-list-item-props branch November 7, 2025 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-S team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants