-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(ramp): agg / deposit switcher #22283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
cursor review |
|
Ok 👍🙏
El jue, 6 de nov de 2025 4:04 p. m., Pedro Pablo Aste Kompen <
***@***.***> escribió:
… ***@***.**** commented on this pull request.
------------------------------
In app/component-library/components/List/ListItemSelect/ListItemSelect.tsx
<#22283 (comment)>
:
> @@ -34,7 +35,7 @@ const ListItemSelect: React.FC<ListItemSelectProps> = ({
onLongPress={onLongPress}
{...props}
>
- <ListItem gap={gap} style={styles.listItem}>
+ <ListItem gap={gap} style={styles.listItem} {...listItemProps}>
ignore these changes because the are handled here #22277
<#22277>
once updating with main they will not be relevant
—
Reply to this email directly, view it on GitHub
<#22283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHZMWQ5Z2FJCPSSJQVKZH3L33PAXRAVCNFSM6AAAAACLMCDDXCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMZQG4ZTMNBYGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
app/components/UI/Ramp/Aggregator/Views/Modals/Settings/SettingsModal.tsx
Show resolved
Hide resolved
app/components/UI/Ramp/Deposit/Views/Modals/ConfigurationModal/ConfigurationModal.tsx
Show resolved
Hide resolved
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
|
| }); | ||
| }); | ||
|
|
||
| describe('menu item icons', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these tests feel a bit redundant, wdyt? I think a single snapshot would cover the case for all of these text assertions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, there's already a snapshot. cursor generated these and made sense to me anyway.



Description
This pull request introduces a new "Settings" modal for the buy flow in the Ramp Aggregator, updates the configuration button icon, and improves component flexibility and test coverage. The most significant changes are the addition of the buy settings modal and its integration into the navigation flow.
Buy Flow Settings Modal
SettingsModalcomponent that appears as a bottom sheet, allowing users to view order history or switch to the new buy experience. This includes navigation logic and UI elements. [1] [2] [3]SettingsModalinto the Ramp Aggregator's modal navigation stack, making it accessible from the buy flow. [1] [2]createBuySettingsModalNavigationDetails). [1] [2]UI/UX Improvements
Testing
SettingsModal, verifying rendering, navigation, and user interactions.Figma Link
Changelog
CHANGELOG entry: Add settings modal for Buy and a switcher between Buy and Deposit
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TRAM-2825
Manual testing steps
Screenshots/Recordings
Before
After
Buy
Buy Settings
Deposit
Deposit Settings
Switcher
switcher.mp4
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces a new buy Settings bottom sheet and navigation, adds a reusable MenuItem component, updates deposit config UI (incl. new Setting icon) and strings, and wires a switcher between Buy (Aggregator) and Deposit.
SettingsModalbottom sheet (Routes.RAMP.MODALS.SETTINGS), opened fromBuildQuotewhen buying; options to view order history and switch to Deposit.routes/index.tsxand providescreateBuySettingsModalNavigationDetails.MenuItem, adds "More ways to buy" to navigate to Aggregator; keeps order history/support/logout; removes old styles file.IconName.Setting.app/components/UI/Ramp/components/MenuItem) with icon/title/optional description.RampSettingsModalroute key.SettingsModalandMenuItem; updates snapshots for icon/name and new UI.Written by Cursor Bugbot for commit 9c02608. This will update automatically on new commits. Configure here.