Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 9, 2025

Description

Add polymarket_account_created property to transaction events if Predict deposit creates Safe proxy.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #5944

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds polymarket_account_created metric to Predict deposit transactions by detecting Safe proxy creation via 4-byte prefix, with accompanying tests.

  • Metrics:
    • Add polymarket_account_created to getMetaMaskPayProperties for predictDeposit based on nested tx data starting with 0xa1884d2c.
    • Introduce FOUR_BYTE_SAFE_PROXY_CREATE constant for detection.
  • Tests:
    • Add tests asserting polymarket_account_created is set to true/false depending on presence of matching nested transaction.

Written by Cursor Bugbot for commit 0092914. This will update automatically on new commits. Configure here.

@matthewwalsh0 matthewwalsh0 added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Nov 9, 2025
@github-actions github-actions bot added the size-S label Nov 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2025

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review November 10, 2025 10:51
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner November 10, 2025 10:51
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 10, 2025
Merged via the queue into main with commit dd20380 Nov 10, 2025
101 of 102 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/predict-deposit-account-metric branch November 10, 2025 11:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants