Skip to content

feat: predict deposit account created metric #22366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
+40 −13
Merged

feat: predict deposit account created metric #22366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 32 additions & 13 deletions app/core/Engine/controllers/transaction-controller/event_properties/metamask-pay.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,6 @@ describe('Metamask Pay Metrics', () => {
});
});

it('returns nothing if predict_deposit', () => {
request.transactionMeta.nestedTransactions = [
{ type: TransactionType.predictDeposit },
];

const result = getMetaMaskPayProperties(request);

expect(result).toStrictEqual({
properties: {},
sensitiveProperties: {},
});
});

it('copies properties from parent transaction if bridge', () => {
getUIMetricsMock.mockReturnValue({
properties: {
Expand Down Expand Up @@ -359,4 +346,36 @@ describe('Metamask Pay Metrics', () => {

expect(result.properties.mm_pay_dust_usd).toBeUndefined();
});

it('sets polymarket_account_created as true if predict deposit and matching nested transaction', () => {
request.transactionMeta.nestedTransactions = [
{ type: TransactionType.predictDeposit },
{ data: '0xa1884d2c1234' },
];

const result = getMetaMaskPayProperties(request);

expect(result).toStrictEqual({
properties: {
polymarket_account_created: true,
},
sensitiveProperties: {},
});
});

it('sets polymarket_account_created as false if predict deposit with no matching nested transaction', () => {
request.transactionMeta.nestedTransactions = [
{ type: TransactionType.predictDeposit },
{ data: '0xa1884d2d' },
];

const result = getMetaMaskPayProperties(request);

expect(result).toStrictEqual({
properties: {
polymarket_account_created: false,
},
sensitiveProperties: {},
});
});
});
8 changes: 8 additions & 0 deletions app/core/Engine/controllers/transaction-controller/event_properties/metamask-pay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { orderBy } from 'lodash';
import { NATIVE_TOKEN_ADDRESS } from '../../../../../components/Views/confirmations/constants/tokens';
import { hasTransactionType } from '../../../../../components/Views/confirmations/utils/transaction';

const FOUR_BYTE_SAFE_PROXY_CREATE = '0xa1884d2c';

const COPY_METRICS = [
'mm_pay',
'mm_pay_use_case',
Expand Down Expand Up @@ -32,6 +34,12 @@ export const getMetaMaskPayProperties: TransactionMetricsBuilder = ({
(batchId && hasTransactionType(tx, PAY_TYPES) && tx.batchId === batchId),
);

if (hasTransactionType(transactionMeta, [TransactionType.predictDeposit])) {
properties.polymarket_account_created = (
transactionMeta?.nestedTransactions ?? []
).some((t) => t.data?.startsWith(FOUR_BYTE_SAFE_PROXY_CREATE));
}

if (hasTransactionType(transactionMeta, PAY_TYPES) || !parentTransaction) {
return {
properties,
Expand Down
Loading