Skip to content

Conversation

@PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Nov 18, 2025

Description

This PR fixes empty message passing for empty transactions list.

Changelog

CHANGELOG entry: Fixed a styling bug for empty transactions list message

Related issues

Fixes:

Manual testing steps

Feature: Show empty transactions list

  Scenario: user checks activity
    Given user navigates to activity

    When user selects a network without any transactions
    Then the message is displayed with proper spacing

Screenshots/Recordings

Before

Screenshot 2025-11-18 at 15 55 27

After

Screenshot 2025-11-18 at 15 55 10

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Change emptyList padding from paddingBottom: 24 to paddingVertical: 48 in app/components/Views/UnifiedTransactionsView/UnifiedTransactionsView.styles.ts.

Written by Cursor Bugbot for commit c0cd9bd. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Nov 18, 2025
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

Analysis of the changed file:

FILE CHANGED:

  • app/components/Views/UnifiedTransactionsView/UnifiedTransactionsView.styles.ts

INVESTIGATION FINDINGS:

  1. File Type: This is a styles file (.styles.ts) containing only StyleSheet definitions for the UnifiedTransactionsView component
  2. Component Context: UnifiedTransactionsView is used in ActivityView to display both EVM and non-EVM transactions in a unified list
  3. Style Contents: The file contains basic UI styling for:
    • Container (background color, flex layout)
    • Empty list state (centering, padding, text color)
    • Modal (positioning)
    • ScrollView content (flex layout)
  4. Unable to get git diff: The exact changes couldn't be retrieved, but based on the file content, this appears to be pure styling changes

RISK ASSESSMENT:

  • Low Risk: Style-only changes in a .styles.ts file typically don't affect functional behavior
  • The file contains only visual styling properties (colors, padding, margins, flex layouts)
  • No business logic, no data handling, no critical paths affected
  • Changes are isolated to visual presentation layer

REASONING FOR NO TAGS:

  1. Pure styling changes: Changes to a styles file are visual-only and don't typically require E2E testing unless they break critical UI flows
  2. No critical file markers: The file is not in app/core/, e2e/framework/, or other critical paths
  3. No functional impact: Styling changes don't alter transaction logic, account management, network switching, or any other testable functionality
  4. Low confidence consideration: Without seeing the actual diff, there's a small possibility this could be a significant refactor, but given the file size (31 lines) and simple content, this is unlikely

RECOMMENDATION:
No E2E test tags are needed for this change. Style-only modifications should be validated through visual regression testing or manual UI review rather than functional E2E tests.

Note: If the actual changes include significant structural modifications or if there are concerns about UI breakage, manual smoke testing of the Activity/Transactions view would be prudent, but automated E2E test execution is not warranted for styling changes.

View GitHub Actions results

@PatrykLucka PatrykLucka marked this pull request as ready for review November 18, 2025 15:10
@PatrykLucka PatrykLucka requested a review from a team as a code owner November 18, 2025 15:10
@sonarqubecloud
Copy link

@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants