Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVERT] Revert Segment related changes for 6.2.0 #5991

Merged
merged 4 commits into from
Mar 20, 2023
Merged

[REVERT] Revert Segment related changes for 6.2.0 #5991

merged 4 commits into from
Mar 20, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Mar 18, 2023

Description

This PR reverts 3 PRs related to Segment integration
1 - #5892
2 - #5863
3 - #5139

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner March 18, 2023 01:16
@Cal-L Cal-L changed the base branch from main to release/6.2.0 March 18, 2023 01:16
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.2.0 Issue or pull request that will be included in release 6.2.0 team-mobile-client regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead labels Mar 18, 2023
@Cal-L Cal-L changed the title Revert/6.2.0 segment [REVERT] Revert Segment related changes for 6.2.0 Mar 18, 2023
sethkfman
sethkfman approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tommasini
tommasini approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added the QA Passed A successful QA run through has been done label Mar 20, 2023
cortisiko
cortisiko approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

@cortisiko cortisiko removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead labels Mar 20, 2023
@chrisleewilcox chrisleewilcox merged commit 94928db into release/6.2.0 Mar 20, 2023
@chrisleewilcox chrisleewilcox deleted the revert/6.2.0-segment branch March 20, 2023 23:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-platform Mobile Platform team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@cortisiko cortisiko cortisiko approved these changes

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.2.0 Issue or pull request that will be included in release 6.2.0 team-mobile-platform Mobile Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Cal-L @sethkfman @cortisiko @tommasini @chrisleewilcox @gauthierpetetin