Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVERT] Move eth_sendTransaction method handler to a separate module (#5968) #6021

Merged
merged 1 commit into from
Mar 22, 2023
Merged

[REVERT] Move eth_sendTransaction method handler to a separate module (#5968) #6021

merged 1 commit into from
Mar 22, 2023
+10 −278

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Mar 22, 2023

Description

This reverts commit 49a6305. It was reported from @BelfordZ & QA that the changes resulted in a BigInt issue being thrown on Android.

Issue
Reverts #5968

Testing
Try sending legacy transaction. It should be working and should not throw any errors.
Reference convos from slack: https://consensys.slack.com/archives/CBW7S9FSN/p1679427170122229, https://consensys.slack.com/archives/C02U025CVU4/p1679445188858539

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner March 22, 2023 18:51
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L marked this pull request as draft March 22, 2023 18:55
@Cal-L
Copy link
Contributor Author

Cal-L commented Mar 22, 2023

@Gudahtt Will be creating a PR to remove @metamask/utils dependency

@Cal-L Cal-L marked this pull request as ready for review March 22, 2023 19:01
Gudahtt
Gudahtt approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-6.3.0 Issue or pull request that will be included in release 6.3.0 team-mobile-client and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Mar 22, 2023
tommasini
tommasini approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Cal-L Cal-L merged commit 3b02cc9 into main Mar 22, 2023
@Cal-L Cal-L deleted the revert/5968-extract-eth_sendTransaction branch March 22, 2023 19:28
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
release-6.3.0 Issue or pull request that will be included in release 6.3.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cal-L @Gudahtt @tommasini @gauthierpetetin