Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(whats-new-modal): remove onramp content #6542

Closed
wants to merge 2 commits into from

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jun 6, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR removes on-ramp what's new modal content.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei requested a review from a team as a code owner June 6, 2023 17:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hesterbruikman hesterbruikman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 7, 2023
@sethkfman sethkfman changed the base branch from main to release/7.0.1 June 7, 2023 19:53
@sethkfman sethkfman changed the base branch from release/7.0.1 to main June 7, 2023 19:54
@sethkfman
Copy link
Contributor

Closed and merged into hotfix branch here: #6558

@sethkfman sethkfman closed this Jun 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
@wachunei wachunei deleted the refactor/whatsnew-remove-onramp branch September 25, 2023 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants