Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(whats-new-modal): remove onramp content #6558

Merged
merged 1 commit into from
Jun 7, 2023
Merged

refactor(whats-new-modal): remove onramp content #6558

merged 1 commit into from
Jun 7, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jun 7, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
Based on #6542
This PR removes on-ramp what's new modal content for release/7.0.1

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei
refactor(whats-new-modal): remove onramp content
7e32f39 
refactor(whats-new-modal): remove onramp translations
@wachunei wachunei requested a review from a team as a code owner June 7, 2023 20:11
sethkfman
sethkfman approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman mentioned this pull request Jun 7, 2023
Closed
3 tasks
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. release-7.0.1 Issue or pull request that will be included in release 7.0.1 QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jun 7, 2023
chrisleewilcox
chrisleewilcox approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit 9c563db into release/7.0.1 Jun 7, 2023
@chrisleewilcox chrisleewilcox deleted the fix/release-7.0.1-remove-whats-new-content branch June 7, 2023 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.0.1 Issue or pull request that will be included in release 7.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @chrisleewilcox @sethkfman