Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename signature events #7106

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix: rename signature events #7106

merged 1 commit into from
Sep 15, 2023

Conversation

segun
Copy link
Contributor

@segun segun commented Sep 1, 2023

Description
We want to bring mobile and extension metrics closer to parity. This task is to make the signature events the same on both platforms.

Tasks

  • Rename Sign Request Started event to Signature Requested
  • Rename Sign Request Completed event to Signature Approved
  • Rename Sign Request Cancelled event to Signature Rejected

References

Issue
Fixes: #6919

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@segun segun requested a review from a team as a code owner September 1, 2023 13:54
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@segun segun self-assigned this Sep 1, 2023
@segun segun changed the title rename signature events fix: rename signature events Sep 1, 2023
@segun segun added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PR from the confirmations team labels Sep 5, 2023
@segun segun force-pushed the olu/rename-signature-events branch from aaa8150 to 3cf3674 Compare September 7, 2023 14:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@segun segun merged commit 3153aaa into main Sep 15, 2023
@segun segun deleted the olu/rename-signature-events branch September 15, 2023 10:22
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blackdevelopa blackdevelopa blackdevelopa approved these changes

@jpuri jpuri jpuri approved these changes

Assignees

@segun segun

Labels
release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename 3 signature events on mobile
4 participants
@segun @jpuri @blackdevelopa @metamaskbot