Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename signature events #7106

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix: rename signature events #7106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/UI/MessageSign/MessageSign.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class MessageSign extends PureComponent<MessageSignProps, MessageSignState> {
messageParams: { metamaskId },
} = this.props;
AnalyticsV2.trackEvent(
MetaMetricsEvents.SIGN_REQUEST_STARTED,
MetaMetricsEvents.SIGNATURE_REQUESTED,
getAnalyticsParams(),
);
addSignatureErrorListener(metamaskId, this.onSignatureError);
Expand Down
6 changes: 3 additions & 3 deletions app/components/UI/PersonalSign/PersonalSign.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const PersonalSign = ({

useEffect(() => {
AnalyticsV2.trackEvent(
MetaMetricsEvents.SIGN_REQUEST_STARTED,
MetaMetricsEvents.SIGNATURE_REQUESTED,
getAnalyticsParams(),
);
}, [getAnalyticsParams]);
Expand Down Expand Up @@ -112,7 +112,7 @@ const PersonalSign = ({
await onReject();
showWalletConnectNotification(false);
AnalyticsV2.trackEvent(
MetaMetricsEvents.SIGN_REQUEST_CANCELLED,
MetaMetricsEvents.SIGNATURE_REJECTED,
getAnalyticsParams(),
);
};
Expand All @@ -121,7 +121,7 @@ const PersonalSign = ({
await onConfirm();
showWalletConnectNotification(true);
AnalyticsV2.trackEvent(
MetaMetricsEvents.SIGN_REQUEST_COMPLETED,
MetaMetricsEvents.SIGNATURE_APPROVED,
getAnalyticsParams(),
);
};
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/TypedSign/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class TypedSign extends PureComponent {
messageParams: { metamaskId },
} = this.props;
AnalyticsV2.trackEvent(
MetaMetricsEvents.SIGN_REQUEST_STARTED,
MetaMetricsEvents.SIGNATURE_REQUESTED,
getAnalyticsParams(),
);
addSignatureErrorListener(metamaskId, this.onSignatureError);
Expand Down
12 changes: 6 additions & 6 deletions app/core/Analytics/MetaMetrics.events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ enum EVENT_NAME {
CONTRACT_ADDRESS_NICKNAME = 'Contract Address Nickname',

// Sign request
SIGN_REQUEST_STARTED = 'Sign Request Started',
SIGN_REQUEST_COMPLETED = 'Sign Request Completed',
SIGN_REQUEST_CANCELLED = 'Sign Request Cancelled',
SIGNATURE_REQUESTED = 'Signature Requested',
SIGNATURE_APPROVED = 'Signature Approved',
SIGNATURE_REJECTED = 'Signature Rejected',

// Connect request
CONNECT_REQUEST_STARTED = 'Connect Request Started',
Expand Down Expand Up @@ -377,9 +377,9 @@ const events = {
),
CONTRACT_ADDRESS_COPIED: generateOpt(EVENT_NAME.CONTRACT_ADDRESS_COPIED),
CONTRACT_ADDRESS_NICKNAME: generateOpt(EVENT_NAME.CONTRACT_ADDRESS_NICKNAME),
SIGN_REQUEST_STARTED: generateOpt(EVENT_NAME.SIGN_REQUEST_STARTED),
SIGN_REQUEST_COMPLETED: generateOpt(EVENT_NAME.SIGN_REQUEST_COMPLETED),
SIGN_REQUEST_CANCELLED: generateOpt(EVENT_NAME.SIGN_REQUEST_CANCELLED),
SIGNATURE_REQUESTED: generateOpt(EVENT_NAME.SIGNATURE_REQUESTED),
SIGNATURE_APPROVED: generateOpt(EVENT_NAME.SIGNATURE_APPROVED),
SIGNATURE_REJECTED: generateOpt(EVENT_NAME.SIGNATURE_REJECTED),
CONNECT_REQUEST_STARTED: generateOpt(EVENT_NAME.CONNECT_REQUEST_STARTED),
CONNECT_REQUEST_COMPLETED: generateOpt(EVENT_NAME.CONNECT_REQUEST_COMPLETED),
CONNECT_REQUEST_OTPFAILURE: generateOpt(
Expand Down
4 changes: 2 additions & 2 deletions app/util/confirmation/signatureUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ export const handleSignatureAction = async (
showWalletConnectNotification(messageParams, confirmation);
AnalyticsV2.trackEvent(
confirmation
? MetaMetricsEvents.SIGN_REQUEST_COMPLETED
: MetaMetricsEvents.SIGN_REQUEST_CANCELLED,
? MetaMetricsEvents.SIGNATURE_APPROVED
: MetaMetricsEvents.SIGNATURE_REJECTED,
getAnalyticsParams(messageParams, signType),
);
};
Expand Down