fix: add RN patch for boost (#8221) #8222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description** * RN was failing because of a down 3rd parties dependencies called [boost](https://www.boost.org/) which is a C++ utility library. * RN suggested [this fix](facebook/react-native#42180) * But another file in react-native [needed to be updated for Android](software-mansion/react-native-reanimated#5542) as well _The boost library URL needed to be updated in 2 places_ **This PR incorporates both updates of the boost library download URL into the patch of react-native** Smoke tests passing: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/675c4c9f-22b4-461b-803c-04d3db6dd595 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
frankvonhoven
added
No QA Needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/7.14.0 #8222 +/- ##
=================================================
Coverage ? 37.27%
=================================================
Files ? 1139
Lines ? 29155
Branches ? 2743
=================================================
Hits ? 10868
Misses ? 17655
Partials ? 632 ☔ View full report in Codecov by Sentry. |
|
metamaskbot
added
the
release-7.14.0
|
No release label on PR. Adding release label release-7.14.0 on PR, as PR was added to branch 7.14.0 when release was cut. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick PR for:
RN was failing because of a down 3rd parties dependencies called boost which is a C++ utility library.
RN suggested this fix
But another file in react-native needed to be updated for Android as well
The boost library URL needed to be updated in 2 places This PR incorporates both updates of the boost library download URL into the patch of react-native
Smoke tests passing:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/675c4c9f-22b4-461b-803c-04d3db6dd595
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist