Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The boost_1_76_0.tar.gz file is not in GZIP format #5542

Closed
ravisharnagat opened this issue Dec 31, 2023 · 75 comments
Closed

The boost_1_76_0.tar.gz file is not in GZIP format #5542

ravisharnagat opened this issue Dec 31, 2023 · 75 comments
Labels
Missing repro This issue need minimum repro scenario Needs review Issue is ready to be reviewed by a maintainer Platform: Android This issue is specific to Android

Comments

@ravisharnagat
Copy link

ravisharnagat commented Dec 31, 2023

Description

Getting following error on android build creation:

Execution failed for task ':react-native-reanimated:prepareBoost'.
13:32:31 > Could not read /home/ubuntu/workspace/Feature-Testing-D11/Feature-testing/AndroidAdhocBuildsNew_FLIP/node_modules/react-native-reanimated/android/build/downloads/boost_1_76_0.tar.gz.
13:32:31    > Not in GZIP format

Steps to reproduce

Execution is failing for the step where boost is prepared, because the downloaded tar.gz file (https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.tar.gz) is not present in gzip format. Please check the screenshot attached.
Screenshot 2023-12-31 at 1 55 48 PM

Snack or a link to a repository

github.com/eternal_mercy_2/test-reanimated

Reanimated version

3.3.0

React Native version

0.69.1

Platforms

Android

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

@ravisharnagat ravisharnagat added the Needs review Issue is ready to be reviewed by a maintainer label Dec 31, 2023
@github-actions github-actions bot added the Missing repro This issue need minimum repro scenario label Dec 31, 2023
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added the Platform: Android This issue is specific to Android label Dec 31, 2023
@Kprashanth20
Copy link

facing the same issue. any solution?

@Ehabwazery
Copy link

same issue

@hodayaGruzm
Copy link

i have the same issue, any updates?

@Adwait5522
Copy link

Any Updates?

@Don-oneself
Copy link

same issue

@aryanagarwal15
Copy link

Same error, needs urgent attention

@Ehabwazery
Copy link

anyone found a solution ?

@abed-obaah
Copy link

abed-obaah commented Dec 31, 2023

any solution yet?

@ssommelet21
Copy link

Currently, the ball is here :

facebook/react-native#42110 (comment)

@Linuhusainnk
Copy link

Any updates on the issue prepareBoost failed

@abed-obaah
Copy link

abed-obaah commented Jan 1, 2024 via email

@chaimPaneth
Copy link

Jfrog redirects the boost source download to this https://landing.jfrog.com/reactivate-server/boostorg with an account reactivation notice.

Just replace

spec.source = { :http => 'https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.tar.bz2',
                  :sha256 => 'f0397ba6e982c4450f27bf32a2a83292aba035b827a5623a14636ea583318c41' }

in /node_modules/react-native/third-party-podspecs/boost.podspec with

spec.source = { :http => 'https://sourceforge.net/projects/boost/files/boost/1.76.0/boost_1_76_0.tar.bz2',
                  :sha256 => 'f0397ba6e982c4450f27bf32a2a83292aba035b827a5623a14636ea583318c41' }

Then you can also patch-package react-native for future installs.

@Temitope-Emmanuel
Copy link

Jfrog redirects the boost source download to this https://landing.jfrog.com/reactivate-server/boostorg with an account reactivation notice.

Just replace

spec.source = { :http => 'https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.tar.bz2',
                  :sha256 => 'f0397ba6e982c4450f27bf32a2a83292aba035b827a5623a14636ea583318c41' }

in /node_modules/react-native/third-party-podspecs/boost.podspec with

spec.source = { :http => 'https://sourceforge.net/projects/boost/files/boost/1.76.0/boost_1_76_0.tar.bz2',
                  :sha256 => 'f0397ba6e982c4450f27bf32a2a83292aba035b827a5623a14636ea583318c41' }

Then you can also patch-package react-native for future installs.

I wasn't able to get it to work, has anyone tried this ?

@chaimPaneth
Copy link

@Temitope-Emmanuel

It worked for me. Make sure to run rm -rf Pods/ Podfile.lock before hand. Also if your using M1 mac run first bundle install and bundle exec pod install instead of just pod install.

@Temitope-Emmanuel
Copy link

@Temitope-Emmanuel

It worked for me. Make sure to run rm -rf Pods/ Podfile.lock before hand. Also if your using M1 mac run first bundle install and bundle exec pod install instead of just pod install.

It's my android build that's failing, it's the same error message that's why I'm on this thread

@abed-obaah
Copy link

has anyone solved it yet?. the solutions provided aren't fixing it

@ravisharnagat
Copy link
Author

ravisharnagat commented Jan 1, 2024

For Android, one quick workaround is to create patch-package for package react-native-reanimated.

Just replace

    task downloadBoost(dependsOn: resolveBoost, type: Download) {
        def transformedVersion = BOOST_VERSION.replace("_", ".")
        def artifactLocalName = "boost_${BOOST_VERSION}.tar.gz"
        def srcUrl = "https://boostorg.jfrog.io/artifactory/main/release/${transformedVersion}/source/boost_${BOOST_VERSION}.tar.gz"
        if (REACT_NATIVE_MINOR_VERSION < 69) {
            srcUrl = "https://github.com/react-native-community/boost-for-react-native/releases/download/v${transformedVersion}-0/boost_${BOOST_VERSION}.tar.gz"
        }
        src(srcUrl)
        onlyIfNewer(true)
        overwrite(false)
        dest(new File(downloadsDir, artifactLocalName))
    }

in /node_modules/react-native-reanimated/android/build.gradle with

task downloadBoost(dependsOn: resolveBoost, type: Download) {
        def transformedVersion = BOOST_VERSION.replace("_", ".")
        def artifactLocalName = "boost_${BOOST_VERSION}.tar.gz"
        
        def srcUrl = "https://sourceforge.net/projects/boost/files/boost/${transformedVersion}/boost_${BOOST_VERSION}.tar.gz"
        if (REACT_NATIVE_MINOR_VERSION < 69) {
            srcUrl = "https://github.com/react-native-community/boost-for-react-native/releases/download/v${transformedVersion}-0/boost_${BOOST_VERSION}.tar.gz"
        }
        src(srcUrl)
        onlyIfNewer(true)
        overwrite(false)
        dest(new File(downloadsDir, artifactLocalName))
    }

This should fix the android build issue for timebeing. @Temitope-Emmanuel

Make sure to delete the previously downloaded file boost_1_76_0.tar.gz in react-native-reanimated/android/build/downloads

@abed-obaah
Copy link

For Android, one quick workaround is to create patch-package for package react-native-reanimated.

Just replace

    task downloadBoost(dependsOn: resolveBoost, type: Download) {
        def transformedVersion = BOOST_VERSION.replace("_", ".")
        def artifactLocalName = "boost_${BOOST_VERSION}.tar.gz"
        def srcUrl = "https://boostorg.jfrog.io/artifactory/main/release/${transformedVersion}/source/boost_${BOOST_VERSION}.tar.gz"
        if (REACT_NATIVE_MINOR_VERSION < 69) {
            srcUrl = "https://github.com/react-native-community/boost-for-react-native/releases/download/v${transformedVersion}-0/boost_${BOOST_VERSION}.tar.gz"
        }
        src(srcUrl)
        onlyIfNewer(true)
        overwrite(false)
        dest(new File(downloadsDir, artifactLocalName))
    }

in /node_modules/react-native-reanimated/android/build.gradle with

        task downloadBoost(dependsOn: resolveBoost, type: Download) {
        def transformedVersion = BOOST_VERSION.replace("_", ".")
        def artifactLocalName = "boost_${BOOST_VERSION}.tar.gz"
        
        def srcUrl = "https://sourceforge.net/projects/boost/files/boost/${transformedVersion}/boost_${BOOST_VERSION}.tar.gz"
        if (REACT_NATIVE_MINOR_VERSION < 69) {
            srcUrl = "https://github.com/react-native-community/boost-for-react-native/releases/download/v${transformedVersion}-0/boost_${BOOST_VERSION}.tar.gz"
        }
        src(srcUrl)
        onlyIfNewer(true)
        overwrite(false)
        dest(new File(downloadsDir, artifactLocalName))
    }

This should fix the android build issue for timebeing. @Temitope-Emmanuel

what about for managed workflow

@247Sam
Copy link

247Sam commented Jan 1, 2024

For Android, one quick workaround is to create patch-package for package react-native-reanimated.

Just replace

    task downloadBoost(dependsOn: resolveBoost, type: Download) {
        def transformedVersion = BOOST_VERSION.replace("_", ".")
        def artifactLocalName = "boost_${BOOST_VERSION}.tar.gz"
        def srcUrl = "https://boostorg.jfrog.io/artifactory/main/release/${transformedVersion}/source/boost_${BOOST_VERSION}.tar.gz"
        if (REACT_NATIVE_MINOR_VERSION < 69) {
            srcUrl = "https://github.com/react-native-community/boost-for-react-native/releases/download/v${transformedVersion}-0/boost_${BOOST_VERSION}.tar.gz"
        }
        src(srcUrl)
        onlyIfNewer(true)
        overwrite(false)
        dest(new File(downloadsDir, artifactLocalName))
    }

in /node_modules/react-native-reanimated/android/build.gradle with

task downloadBoost(dependsOn: resolveBoost, type: Download) {
        def transformedVersion = BOOST_VERSION.replace("_", ".")
        def artifactLocalName = "boost_${BOOST_VERSION}.tar.gz"
        
        def srcUrl = "https://sourceforge.net/projects/boost/files/boost/${transformedVersion}/boost_${BOOST_VERSION}.tar.gz"
        if (REACT_NATIVE_MINOR_VERSION < 69) {
            srcUrl = "https://github.com/react-native-community/boost-for-react-native/releases/download/v${transformedVersion}-0/boost_${BOOST_VERSION}.tar.gz"
        }
        src(srcUrl)
        onlyIfNewer(true)
        overwrite(false)
        dest(new File(downloadsDir, artifactLocalName))
    }

This should fix the android build issue for timebeing. @Temitope-Emmanuel

This worked for me. Make sure to delete the previously downloaded file boost_1_76_0.tar.gz in react-native-reanimated/android/build/downloads

@Dhinakrish
Copy link

@ravisharnagat Thank for your solution Its worked for me to generate Android build

@clifford-karta
Copy link

clifford-karta commented Jan 2, 2024

Does anyone able to solve this issue on building in GitHub Actions/ Workflow?

@Linuhusainnk
Copy link

Is it resolved or apply patch, which would be better ?

@chandresh8187
Copy link

same issue

@hrhm47
Copy link

hrhm47 commented Jan 2, 2024

@ravisharnagat thank you it works for me... i'm still confused abut GZIP format in reanimated......
any one knows why this problems comes just clear my concept about it.

@ssommelet21
Copy link

@ravisharnagat thank you it works for me... i'm still confused abut GZIP format in reanimated...... any one knows why this problems comes just clear my concept about it.

The problem is not in "node_modules/react-native-reanimated" but in the "node_modules/react-native".

Boost is a portable C++ source libraries need to the compilation :

https://www.boost.org

@brianwestphal
Copy link

Raised boostorg/boost#849

@dsumayan21
Copy link

same here. react native v 0.69.9

image

@imamrobani
Copy link

As mentioned above,

In /node_modules/react-native-reanimated/android/build.gradle

Change this:

def srcUrl = "https://boostorg.jfrog.io/artifactory/main/release/${transformedVersion}/source/boost_${BOOST_VERSION}.tar.gz"

To This:

def srcUrl = "https://sourceforge.net/projects/boost/files/boost/${transformedVersion}/boost_${BOOST_VERSION}.tar.gz"

Make sure to delete the previously downloaded file boost_1_76_0.tar.gz in react-native-reanimated/android/build/downloads

temporary it's work, thanks!

@devwizard038
Copy link

As mentioned above,
In /node_modules/react-native-reanimated/android/build.gradle
Change this:

def srcUrl = "https://boostorg.jfrog.io/artifactory/main/release/${transformedVersion}/source/boost_${BOOST_VERSION}.tar.gz"

To This:

def srcUrl = "https://sourceforge.net/projects/boost/files/boost/${transformedVersion}/boost_${BOOST_VERSION}.tar.gz"

Make sure to delete the previously downloaded file boost_1_76_0.tar.gz in react-native-reanimated/android/build/downloads

temporary it's work, thanks!

How do I set it in expo? I think when running "eas build", all the dependencies are uploaded to the cloud server and download packages automatically so I can't change the code or values in the packages. How can I do it?

@ergulemre
Copy link

it is solved Migrate boost download away from JFrog

@devwizard038
Copy link

Is it fixed for expo-module-core too?

@devwizard038
Copy link

image
image
Still the same issue. Please help me with this.

@passiondroid
Copy link

As mentioned above,
In /node_modules/expo-modules-core/android/build.gradle
Change this:

def srcUrl = "https://boostorg.jfrog.io/artifactory/main/release/${transformedVersion}/source/boost_${BOOST_VERSION}.tar.gz"
To This:

def srcUrl = "https://sourceforge.net/projects/boost/files/boost/${transformedVersion}/boost_${BOOST_VERSION}.tar.gz"

And then create a patch file using this command -
npx patch-package expo-modules-core

Temporary workaround. Working for me

@Jean-Bekker
Copy link

Fixed the Issue with Boost Library

Step 1: Update URL in ReactAndroid Build Script

  1. Navigate to the file: /node_modules/react-native/ReactAndroid/build.gradle

  2. Locate the following line:

https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION.replace("_", ".")}/source/boost_${BOOST_VERSION}.tar.gz
  1. Replace it with:
https://archives.boost.io/release/${BOOST_VERSION.replace("_", ".")}/source/boost_${BOOST_VERSION}.tar.gz

Step 2: Update URL in Expo Modules Core

  1. Go to the file: /node_modules/expo-modules-core/android/build.gradle.

  2. Search for the same URL as in Step 1.

  3. Replace it with the new URL provided in Step 1.

Step 3: Apply the Patches

After making the changes, run the following commands to apply the patches:

patch-package react-native
patch-package expo-modules-core

@trickeyd
Copy link

trickeyd commented Jan 8, 2024

I applied the patch to:

  • react-native
  • react-native-reanimated
  • expo-modules-core

Now I get this error:

* What went wrong:
Execution failed for task ':react-native-reanimated:unzipHermes'.
> Could not read /Users/***/node_modules/react-native/sdks/download/hermes.tar.gz.
   > java.io.EOFException (no error message)

Not sure how hermes was effected. I have deleted node_modules and cleared the android build cache but to no avail. Anyone else seen this?

@marc-sarroca-thepowermba

same issue here trying to generate builds in AppCenter

@sauravjmedhi-softsensor
Copy link

I applied the patch to:

  • react-native
  • react-native-reanimated
  • expo-modules-core

Now I get this error:

* What went wrong:
Execution failed for task ':react-native-reanimated:unzipHermes'.
> Could not read /Users/***/node_modules/react-native/sdks/download/hermes.tar.gz.
   > java.io.EOFException (no error message)

Not sure how hermes was effected. I have deleted node_modules and cleared the android build cache but to no avail. Anyone else seen this?

A solution given in another issue seems to work: #3590 (comment)

But, how to make this change so that it works in a ci/cd as well?

@BadLice
Copy link

BadLice commented Jan 8, 2024

I applied the patch to:

  • react-native
  • react-native-reanimated
  • expo-modules-core

Now I get this error:

* What went wrong:
Execution failed for task ':react-native-reanimated:unzipHermes'.
> Could not read /Users/***/node_modules/react-native/sdks/download/hermes.tar.gz.
   > java.io.EOFException (no error message)

Not sure how hermes was effected. I have deleted node_modules and cleared the android build cache but to no avail. Anyone else seen this?

I applied the patch only to react-native and react-native-reanimated since i am not using expo and it worked

in react-native you also need to patch an additional file other than the build.gradle (see facebook/react-native#42180)

@Marcuspo
Copy link

Marcuspo commented Jan 8, 2024

same

@lucianomlima
Copy link

I'm getting error for iOS too, during pod install commando in App Center. What I need to change before creating the patch?

Installing boost (1.76.0)

[!] Error installing boost
Verification checksum was incorrect, expected f0397ba6e982c4450f27bf32a2a83292aba035b827a5623a14636ea583318c41, got 5e89103d9b70bba5c91a794126b169cb67654be2051f90cf7c22ba6893ede0ff

##[error]The process '/usr/local/lib/ruby/gems/3.0.0/bin/pod' failed with exit code 1
##[error]The 'pod' command failed with error: The process '/usr/local/lib/ruby/gems/3.0.0/bin/pod' failed with exit code 1
##[section]Finishing: Pod install

@SYoder1
Copy link

SYoder1 commented Jan 8, 2024

I'm getting error for iOS too, during pod install commando in App Center. What I need to change before creating the patch?

Installing boost (1.76.0)

[!] Error installing boost
Verification checksum was incorrect, expected f0397ba6e982c4450f27bf32a2a83292aba035b827a5623a14636ea583318c41, got 5e89103d9b70bba5c91a794126b169cb67654be2051f90cf7c22ba6893ede0ff

##[error]The process '/usr/local/lib/ruby/gems/3.0.0/bin/pod' failed with exit code 1
##[error]The 'pod' command failed with error: The process '/usr/local/lib/ruby/gems/3.0.0/bin/pod' failed with exit code 1
##[section]Finishing: Pod install

@lucianomlima React Native posted a workaround to fix the ios error. facebook/react-native#42180 (comment)

@devwizard038
Copy link

Fixed the Issue with Boost Library

Step 1: Update URL in ReactAndroid Build Script

  1. Navigate to the file: /node_modules/react-native/ReactAndroid/build.gradle
  2. Locate the following line:
https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION.replace("_", ".")}/source/boost_${BOOST_VERSION}.tar.gz
  1. Replace it with:
https://archives.boost.io/release/${BOOST_VERSION.replace("_", ".")}/source/boost_${BOOST_VERSION}.tar.gz

Step 2: Update URL in Expo Modules Core

  1. Go to the file: /node_modules/expo-modules-core/android/build.gradle.
  2. Search for the same URL as in Step 1.
  3. Replace it with the new URL provided in Step 1.

Step 3: Apply the Patches

After making the changes, run the following commands to apply the patches:

patch-package react-native
patch-package expo-modules-core

I tried this method. But still says the same message. Are there any steps I have to do after patch-package?

frankvonhoven added a commit to MetaMask/metamask-mobile that referenced this issue Jan 8, 2024
## **Description**
* RN was failing because of a down 3rd parties dependencies called
[boost](https://www.boost.org/) which is a C++ utility library.

* RN suggested [this
fix](facebook/react-native#42180)
* But another file in react-native [needed to be updated for
Android](software-mansion/react-native-reanimated#5542)
as well

_The boost library URL needed to be updated in 2 places_
**This PR incorporates both updates of the boost library download URL
into the patch of react-native**


Smoke tests passing:

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/675c4c9f-22b4-461b-803c-04d3db6dd595

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
frankvonhoven added a commit to MetaMask/metamask-mobile that referenced this issue Jan 8, 2024
## **Description**
* RN was failing because of a down 3rd parties dependencies called
[boost](https://www.boost.org/) which is a C++ utility library.

* RN suggested [this
fix](facebook/react-native#42180)
* But another file in react-native [needed to be updated for
Android](software-mansion/react-native-reanimated#5542)
as well

_The boost library URL needed to be updated in 2 places_
**This PR incorporates both updates of the boost library download URL
into the patch of react-native**


Smoke tests passing:

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/675c4c9f-22b4-461b-803c-04d3db6dd595

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
sethkfman added a commit to MetaMask/metamask-mobile that referenced this issue Jan 8, 2024
## **Description**
Cherry pick PR for:

* RN was failing because of a down 3rd parties dependencies called
[boost](https://www.boost.org/) which is a C++ utility library.

* RN suggested [this
fix](facebook/react-native#42180)
* But another file in react-native [needed to be updated for
Android](software-mansion/react-native-reanimated#5542)
as well

_The boost library URL needed to be updated in 2 places_ **This PR
incorporates both updates of the boost library download URL into the
patch of react-native**


Smoke tests passing:


https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/675c4c9f-22b4-461b-803c-04d3db6dd595

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution? -->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page... 2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: sethkfman <seth.kaufman@consensys.net>
@dsumayan21
Copy link

Fixed the Issue with Boost Library

Step 1: Update URL in ReactAndroid Build Script

  1. Navigate to the file: /node_modules/react-native/ReactAndroid/build.gradle
  2. Locate the following line:
https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION.replace("_", ".")}/source/boost_${BOOST_VERSION}.tar.gz
  1. Replace it with:
https://archives.boost.io/release/${BOOST_VERSION.replace("_", ".")}/source/boost_${BOOST_VERSION}.tar.gz

Step 2: Update URL in Expo Modules Core

  1. Go to the file: /node_modules/expo-modules-core/android/build.gradle.
  2. Search for the same URL as in Step 1.
  3. Replace it with the new URL provided in Step 1.

Step 3: Apply the Patches

After making the changes, run the following commands to apply the patches:

patch-package react-native
patch-package expo-modules-core

This worked for me. Thanks for the temp fix!

@SHINGPH
Copy link

SHINGPH commented Jan 9, 2024

For Android, one quick workaround is to create patch-package for package react-native-reanimated.

Just replace

    task downloadBoost(dependsOn: resolveBoost, type: Download) {
        def transformedVersion = BOOST_VERSION.replace("_", ".")
        def artifactLocalName = "boost_${BOOST_VERSION}.tar.gz"
        def srcUrl = "https://boostorg.jfrog.io/artifactory/main/release/${transformedVersion}/source/boost_${BOOST_VERSION}.tar.gz"
        if (REACT_NATIVE_MINOR_VERSION < 69) {
            srcUrl = "https://github.com/react-native-community/boost-for-react-native/releases/download/v${transformedVersion}-0/boost_${BOOST_VERSION}.tar.gz"
        }
        src(srcUrl)
        onlyIfNewer(true)
        overwrite(false)
        dest(new File(downloadsDir, artifactLocalName))
    }

in /node_modules/react-native-reanimated/android/build.gradle with

task downloadBoost(dependsOn: resolveBoost, type: Download) {
        def transformedVersion = BOOST_VERSION.replace("_", ".")
        def artifactLocalName = "boost_${BOOST_VERSION}.tar.gz"
        
        def srcUrl = "https://sourceforge.net/projects/boost/files/boost/${transformedVersion}/boost_${BOOST_VERSION}.tar.gz"
        if (REACT_NATIVE_MINOR_VERSION < 69) {
            srcUrl = "https://github.com/react-native-community/boost-for-react-native/releases/download/v${transformedVersion}-0/boost_${BOOST_VERSION}.tar.gz"
        }
        src(srcUrl)
        onlyIfNewer(true)
        overwrite(false)
        dest(new File(downloadsDir, artifactLocalName))
    }

This should fix the android build issue for timebeing. @Temitope-Emmanuel

Make sure to delete the previously downloaded file boost_1_76_0.tar.gz in react-native-reanimated/android/build/downloads

i have tried this fix but now i am having problem with
and now i have downloaded the boost 1_76_0 on sourceforge website and added it to appname/node_modules/react-native-reanimated/android/build/downloads/boost_1_76_0.tar.gz. and now here is the error.

/node_modules/react-native/ReactCommon/cxxreact/CxxModule.h:15:10: fatal error: 'folly/dynamic.h' file not found
#include <folly/dynamic.h>
^~~~~~~~~~~~~~~~~
1 error generated.

@h-assefi
Copy link

h-assefi commented Jan 9, 2024

Fixed the Issue with Boost Library

Step 1: Update URL in ReactAndroid Build Script

  1. Navigate to the file: /node_modules/react-native/ReactAndroid/build.gradle
  2. Locate the following line:
https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION.replace("_", ".")}/source/boost_${BOOST_VERSION}.tar.gz
  1. Replace it with:
https://archives.boost.io/release/${BOOST_VERSION.replace("_", ".")}/source/boost_${BOOST_VERSION}.tar.gz

Step 2: Update URL in Expo Modules Core

  1. Go to the file: /node_modules/expo-modules-core/android/build.gradle.
  2. Search for the same URL as in Step 1.
  3. Replace it with the new URL provided in Step 1.

Step 3: Apply the Patches

After making the changes, run the following commands to apply the patches:

patch-package react-native
patch-package expo-modules-core

This worked for me. Thanks for the fix!

@Jahanzeb009
Copy link

Install this package,

expo-modules-core

This solved my problem.

@marc-sarroca-thepowermba

Seems that is working now again, I tried to do some builds in AppCenter in IOS and Android and works fine!

@piaskowyk
Copy link
Member

piaskowyk commented Jan 9, 2024

In short, the problem happened because the necessary jFrog servers were not working. The solution is to simply update the URL for the dependency repository. You can find an example of how to do this here: link. Alternatively, you can also wait for a few minutes until the servers are back online. For more detailed information, check out this link: link.

@software-mansion software-mansion locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Missing repro This issue need minimum repro scenario Needs review Issue is ready to be reviewed by a maintainer Platform: Android This issue is specific to Android
Projects
None yet
Development

No branches or pull requests