Skip to content

Commit

Permalink
Repo standardization (#18)
Browse files Browse the repository at this point in the history
* Enforcing minimum node version 12 via circleci, .nvmrc, and the package file
* Adding basic .gitattributes file
* Adding basic .editorconfig file
* Updating .gitignore file

* Adding CODEOWNERS file
  • Loading branch information
ryanml authored Apr 13, 2021
1 parent 8e0fcf6 commit 93226cb
Show file tree
Hide file tree
Showing 8 changed files with 32 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ workflows:
jobs:
prep-deps:
docker:
- image: circleci/node:10
- image: circleci/node:12
steps:
- checkout
- run:
Expand All @@ -37,7 +37,7 @@ jobs:

test-lint:
docker:
- image: circleci/node:10
- image: circleci/node:12
steps:
- checkout
- attach_workspace:
Expand All @@ -48,7 +48,7 @@ jobs:

test-unit:
docker:
- image: circleci/node:10
- image: circleci/node:12
steps:
- checkout
- attach_workspace:
Expand All @@ -59,7 +59,7 @@ jobs:

all-tests-pass:
docker:
- image: circleci/node:10
- image: circleci/node:12
steps:
- run:
name: All tests passed
Expand Down
9 changes: 9 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true

[*]
indent_style = space
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
3 changes: 3 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
* text=auto

yarn.lock linguist-generated=false
4 changes: 4 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Lines starting with '#' are comments.
# Each line is a file pattern followed by one or more owners.

* @MetaMask/devs
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
npm-debug.log
yarn-debug.log*
yarn-error.log*
node_modules
package-lock.json
dist/
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v10
v12
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ Note: releaseLock must be called after adding a signed tx to pending transaction

Returns **[Promise][17]<NonceDetails>**

## Running tests

```bash
yarn test
```



[13]: https://github.com/MetaMask/nonce-tracker/blob/587ee0b25e16543330830e71372e0a9b94c166c4/index.js#L13-L159 "Source code on GitHub"
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
"version": "1.1.0",
"description": "Transaction nonce calculation used in MetaMask.",
"main": "dist/index.js",
"engines": {
"node": ">=12.0.0"
},
"scripts": {
"build": "rm -rf ./dist && tsc --project .",
"test": "yarn build && mocha test/nonce-tracker-test.js",
Expand Down

0 comments on commit 93226cb

Please sign in to comment.