Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo standardization #18

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Repo standardization #18

merged 1 commit into from
Apr 13, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 11, 2021

  • Enforcing minimum node version 12 via circleci, .nvmrc, and the package file
  • Adding basic .gitattributes file
  • Adding basic .editorconfig file
  • Updating .gitignore file

Related: https://github.com/MetaMask/MetaMask-planning/issues/32

@ryanml ryanml self-assigned this Apr 11, 2021
@ryanml ryanml requested a review from a team April 11, 2021 05:44
* Enforcing minimum node version 12 via circleci, .nvmrc, and the package file
* Adding basic .gitattributes file
* Adding basic .editorconfig file
* Updating .gitignore file

* Adding CODEOWNERS file
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanml ryanml merged commit 93226cb into master Apr 13, 2021
@ryanml ryanml deleted the repo-standard branch April 13, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants