Skip to content

Create Semgrep Action#1

Merged
NicholasEllul merged 9 commits intomainfrom
ellul/init
Jan 20, 2025
Merged

Create Semgrep Action#1
NicholasEllul merged 9 commits intomainfrom
ellul/init

Conversation

@NicholasEllul
Copy link
Contributor

@NicholasEllul NicholasEllul commented Jan 17, 2025

Summary

This pull request creates a Semgrep plug-in for the MetaMask Security Code Scanner allowing us to leverage semgrep in our scans.

Testing this action

  1. Clone the https://github.com/metamask/appsec-Playground/ repository. It currently uses MetaMask/Security-Code-Scanner@ellul/add-semgrep which is a branch of the code scanner configured to use this pull requests code.
  2. Open a pull request in Appsec-Playground
  3. See that the scan runs semgrep successfully
  4. I've already created an example pull request you can review here) which also showcases how test directories are ignored.

@NicholasEllul NicholasEllul marked this pull request as ready for review January 17, 2025 17:21
@NicholasEllul NicholasEllul requested a review from a team January 17, 2025 17:39
witmicko
witmicko previously approved these changes Jan 17, 2025
witmicko
witmicko previously approved these changes Jan 20, 2025
Run tests and rule validation in CI
@NicholasEllul NicholasEllul merged commit 2d41c78 into main Jan 20, 2025
1 check passed
@NicholasEllul NicholasEllul deleted the ellul/init branch January 20, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants