Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable endowment:long-running in stable #1103

Closed
ritave opened this issue Jan 5, 2023 · 4 comments · Fixed by MetaMask/metamask-extension#17321
Closed

Disable endowment:long-running in stable #1103

ritave opened this issue Jan 5, 2023 · 4 comments · Fixed by MetaMask/metamask-extension#17321
Assignees

Comments

@ritave
Copy link
Contributor

ritave commented Jan 5, 2023

#945 requires rethinking a new API to allow useful Snap use-cases that used this behaviour before.

It's important to support those case, but we also want to avoid scope creep for v1.0.0 release of Snaps.

Outcome

  • Disable endowment:long-running in stable altogether and post a deprecation warning in Flask
  • Add a console warning when using that permission in Flask explaning the deprecation and pointing to a github issue / discussion.
@FrederikBolding
Copy link
Member

Do we just want to remove it in its entirety until we come up with a new solution? Otherwise, we will have to maintain it even though it isn't in use.

@FrederikBolding
Copy link
Member

We agreed in a prioritization call to disable for now in stable and remove all together once we have a replacement API.

@GuillaumeRx
Copy link
Contributor

Use the new SnapController arg excludedPermissions introduced in #1125 to retrict it on the extension side.

@FrederikBolding
Copy link
Member

Closing for now since it is technically fenced correctly, but we should remember to keep the fencing as-is when we remove the Flask fencing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants