Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make authorize() throw on excluded permissions #1125

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Jan 13, 2023

Required for: #1103 & #990

Uses a record of permissions with their associated error to forbid usage of according permissions. The list is passed to the controller params for ease of use between Flask and other versions.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner January 13, 2023 12:32
@GuillaumeRx GuillaumeRx marked this pull request as draft January 13, 2023 12:32
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #1125 (4b58d4a) into main (a409e94) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1125   +/-   ##
=======================================
  Coverage   95.18%   95.19%           
=======================================
  Files         132      132           
  Lines        4216     4224    +8     
  Branches      719      720    +1     
=======================================
+ Hits         4013     4021    +8     
  Misses        203      203           
Impacted Files Coverage Δ
...ages/snaps-controllers/src/snaps/SnapController.ts 95.30% <100.00%> (+0.04%) ⬆️
...s/snaps-controllers/src/snaps/location/location.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GuillaumeRx GuillaumeRx marked this pull request as ready for review January 13, 2023 16:27
@GuillaumeRx GuillaumeRx force-pushed the gr/add-excluded-permissions branch from 8295987 to fda05c1 Compare January 13, 2023 16:27
@GuillaumeRx GuillaumeRx merged commit bd9c71e into main Jan 13, 2023
@GuillaumeRx GuillaumeRx deleted the gr/add-excluded-permissions branch January 13, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants