Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endowment:long-running deprecation warning #1126

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Jan 13, 2023

Progresses: #1103

console.warn() a deprecation warning if a snap with endowment:long-running is started.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner January 13, 2023 16:57
@codecov-commenter
Copy link

Codecov Report

Merging #1126 (04444bb) into main (bd9c71e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1126   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files         132      132           
  Lines        4224     4226    +2     
  Branches      720      721    +1     
=======================================
+ Hits         4021     4023    +2     
  Misses        203      203           
Impacted Files Coverage Δ
...ages/snaps-controllers/src/snaps/SnapController.ts 95.32% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GuillaumeRx GuillaumeRx merged commit d3a083e into main Jan 13, 2023
@GuillaumeRx GuillaumeRx deleted the gr/add-long-running-deprecation-warning branch January 13, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants