Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Selector component #2640

Closed
FrederikBolding opened this issue Aug 15, 2024 · 0 comments · Fixed by MetaMask/metamask-extension#26675
Closed

Add Selector component #2640

FrederikBolding opened this issue Aug 15, 2024 · 0 comments · Fixed by MetaMask/metamask-extension#26675
Assignees
@FrederikBolding
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0

Comments

@FrederikBolding
Copy link
Member

"Rich" dropdown with more detailed elements than just text.

Details TBD
@FrederikBolding FrederikBolding changed the title Add Selector components Add Selector component Aug 15, 2024
@FrederikBolding FrederikBolding self-assigned this Aug 19, 2024
@FrederikBolding FrederikBolding mentioned this issue Aug 27, 2024
Merged
FrederikBolding added a commit to MetaMask/metamask-extension that referenced this issue Aug 29, 2024
@FrederikBolding @hmalik88 @ritave
chore: Bump Snaps dependencies (#26675)
e177ba0 
## **Description**
Bump snaps packages to latest and handle breaking changes.

Summary of changes in the snaps deps:
- Add `Selector` component
- Add `Icon` component
- Add `color` prop to `Text` component
- `Button` children are now allowed to be `Image` and `Icon`

Closes MetaMask/snaps#2640
Closes MetaMask/MetaMask-planning#1615
Closes MetaMask/snaps#2658
Closes MetaMask/snaps#2639

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26675?quickstart=1)

---------

Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
Co-authored-by: Olaf Tomalka <olaf@tomalka.me>
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederikBolding FrederikBolding

Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Bump Snaps dependencies MetaMask/metamask-extension
2 participants
@FrederikBolding @metamaskbot