Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Button to wrap more elements #2639

Closed
FrederikBolding opened this issue Aug 15, 2024 · 2 comments · Fixed by #2641 or MetaMask/metamask-extension#26675
Closed

Allow Button to wrap more elements #2639

FrederikBolding opened this issue Aug 15, 2024 · 2 comments · Fixed by #2641 or MetaMask/metamask-extension#26675
Assignees
@ritave
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0

Comments

@FrederikBolding
Copy link
Member

Allow Button to wrap more elements such as Image, Icon etc.
@ritave ritave self-assigned this Aug 16, 2024
@ritave ritave mentioned this issue Aug 16, 2024
Merged
@ritave ritave closed this as completed in 4c532f7 Aug 19, 2024
@FrederikBolding FrederikBolding mentioned this issue Aug 27, 2024
Merged
@ajeetd ajeetd reopened this Aug 28, 2024
@ajeetd ajeetd closed this as completed Aug 28, 2024
@ajeetd
Copy link

ajeetd commented Aug 28, 2024

@FrederikBolding will this make it into 12.5 also (release label not set)?

@FrederikBolding
Copy link
Member Author

@ajeetd Depends on when MetaMask/metamask-extension#26675 will be merged

FrederikBolding added a commit to MetaMask/metamask-extension that referenced this issue Aug 29, 2024
@FrederikBolding @hmalik88 @ritave
chore: Bump Snaps dependencies (#26675)
e177ba0 
## **Description**
Bump snaps packages to latest and handle breaking changes.

Summary of changes in the snaps deps:
- Add `Selector` component
- Add `Icon` component
- Add `color` prop to `Text` component
- `Button` children are now allowed to be `Image` and `Icon`

Closes MetaMask/snaps#2640
Closes MetaMask/MetaMask-planning#1615
Closes MetaMask/snaps#2658
Closes MetaMask/snaps#2639

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26675?quickstart=1)

---------

Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
Co-authored-by: Olaf Tomalka <olaf@tomalka.me>
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ritave ritave

Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0
Projects
None yet
Milestone
No milestone
4 participants
@FrederikBolding @ritave @ajeetd @metamaskbot