Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button component now also allows Images and Icons #2641

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

ritave
Copy link
Contributor

@ritave ritave commented Aug 16, 2024

fixes #2639

This PR introduces ability for Button JSX Snap component to have an image or an icon as a pressable element.

@ritave ritave requested a review from a team as a code owner August 16, 2024 12:06
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.27%. Comparing base (1982c5e) to head (b81fa2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2641   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files         478      478           
  Lines        9999     9999           
  Branches     1499     1499           
=======================================
  Hits         9427     9427           
  Misses        572      572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a PR description.

@ritave ritave merged commit 4c532f7 into main Aug 19, 2024
156 checks passed
@ritave ritave deleted the ritave/button branch August 19, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Button to wrap more elements
3 participants