Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation and typing in TransactionParams #3237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Marcofann
Copy link

Fixed incorrect terminology:

  • "Network ID as per EIP-155""Chain ID as per EIP-155" (EIP-155 defines chainId, not network ID).

Fixed spelling mistake:

  • "Maxmimum""Maximum".

Updated incorrect type for nonce:

  • Changed from string to number | string to reflect Ethereum's numeric nonce format while allowing string representations when needed.

@Marcofann Marcofann requested a review from a team as a code owner March 17, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant