Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation and typing in TransactionParams #3237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix documentation and typing in TransactionParams #3237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/snaps-controllers/src/types/controllers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export type TransactionMeta = {
*/
export type TransactionParams = {
/**
* Network ID as per EIP-155.
* Chain ID as per EIP-155.
*/
chainId?: Hex;

Expand Down Expand Up @@ -74,7 +74,7 @@ export type TransactionParams = {
gas?: string;

/**
* Maxmimum number of units of gas to use for this transaction.
* Maximum number of units of gas to use for this transaction.
*/
gasLimit?: string;

Expand Down Expand Up @@ -102,7 +102,7 @@ export type TransactionParams = {
/**
* Unique number to prevent replay attacks.
*/
nonce?: string;
nonce?: number | string;

/**
* Address to send this transaction to.
Expand Down