Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pn548.h missing #70

Closed
teknoraver opened this issue Sep 11, 2016 · 3 comments
Closed

pn548.h missing #70

teknoraver opened this issue Sep 11, 2016 · 3 comments

Comments

@teknoraver
Copy link

teknoraver commented Sep 11, 2016 •
edited
Loading

Compilation error with Mi5 source code and gemini_user_defconfig

  CC      drivers/nfc/pn548/pn548.o
drivers/nfc/pn548/pn548.c:43:19: fatal error: pn548.h: No such file or directory
 #include <pn548.h>
                   ^
compilation terminated.
scripts/Makefile.build:257: recipe for target 'drivers/nfc/pn548/pn548.o' failed
make[3]: *** [drivers/nfc/pn548/pn548.o] Error 1
scripts/Makefile.build:402: recipe for target 'drivers/nfc/pn548' failed
make[2]: *** [drivers/nfc/pn548] Error 2
scripts/Makefile.build:402: recipe for target 'drivers/nfc' failed
make[1]: *** [drivers/nfc] Error 2
Makefile:945: recipe for target 'drivers' failed
make: *** [drivers] Error 2
@h2o64
Copy link

h2o64 commented Sep 11, 2016 •
edited
Loading

"OH! A wild pn548.h appears !!! Catch them all !" https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/gemini-m-oss/drivers/nfc/pn548/pn548.h

(TIP: Replace < > with " " at https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/gemini-m-oss/drivers/nfc/pn548/pn548.c#L43 )

@teknoraver
Copy link
Author

teknoraver commented Sep 11, 2016 •
edited
Loading

yes I know, but they should do it, not me

also, same happens for tspdrv.h, I'm not sure that this are the real sources..

@h2o64
Copy link

h2o64 commented Sep 11, 2016

This kernel is made to be built wih ABS (Android Build System) and not isolated.
They pushed a kernel which works with ABS.
ABS has a specific kernel header managment and that's why your facing this error (and #71 too) so they don't have to be responsable of it

kitakar5525 added a commit to kitakar5525/linux-kernel that referenced this issue Jul 29, 2021
@kitakar5525
(build-fix) misc: tspdrv: fix header inclusion ( <> -> "" )
99526cc 
Build fails with the following message:

    fatal error: tspdrv.h: No such file or directory

Fix this kind of error by replacing <> to "".

Reference:
- Please Correct these lines ! starters are facing problem because of these errors! · Issue #3 · MiCode/Xiaomi_Kernel_OpenSource
  MiCode/Xiaomi_Kernel_OpenSource#3
- pn548.h missing · Issue linux-surface#70 · MiCode/Xiaomi_Kernel_OpenSource
  MiCode/Xiaomi_Kernel_OpenSource#70
- wrong path for tracer_pkt_private.h · Issue linux-surface#71 · MiCode/Xiaomi_Kernel_OpenSource
  MiCode/Xiaomi_Kernel_OpenSource#71

Why this ever happens? From comment in
MiCode/Xiaomi_Kernel_OpenSource#70 (comment),

> This kernel is made to be built wih ABS (Android Build System) and not
> isolated.
> They pushed a kernel which works with ABS.
> ABS has a specific kernel header managment and that's why your facing
> this error (and linux-surface#71 too) so they don't have to be responsable of it

Signed-off-by: Tsuchiya Yuto <kitakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teknoraver @h2o64