Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I started workig on this issue, I wasn't aware of the other PR that was already created regarding support for TLSA.
I've also added RRSIG support though, so the data that can be displayed on a TLSA request is the same as when done with
dig
.I tried to adopt the code styll as much as possible but also added some new methods to make the code around the RRSIG better readable. Also added two unit tests, one for the RRSIG and one for the TLSA
GetRecord
methodsPlease let me know what you think of this.
Best,
Mark