Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TLSA record support #85

Closed
wants to merge 4 commits into from
Closed

Added TLSA record support #85

wants to merge 4 commits into from

Conversation

Zaczero
Copy link

@Zaczero Zaczero commented Aug 28, 2020

Sample code

var lookup = new LookupClient();
var result = lookup.Query("_443._tcp.monicz.pl", QueryType.TLSA);
var record = result.Answers.TlsaRecords().ToArray();

200828180453_devenv_f85342

Notes

One of the tests is failing because current test ZoneData does not contain a response for it (TLSA record). Instead of skipping the check I've decided to leave it as it is as you may add response for it in later time. I am simply not as advanced to modify the ZoneData by myself without breaking it 8) Except for that everything works as intended.

200828180747_devenv_9008a0

@Zaczero
Copy link
Author

Zaczero commented Aug 28, 2020

I genuinely missed the other 2 pull requests for that. Well...

@MichaCo
Copy link
Owner

MichaCo commented Sep 12, 2020

/closing this as duplicate, using #71 and #86 instead
Thanks for the contributions though, always appreciated!

@MichaCo MichaCo closed this Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants