Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for exception regions #62

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Add support for exception regions #62

merged 3 commits into from
Oct 14, 2021

Conversation

mateoatr
Copy link
Collaborator

Should fix #17.

MichalStrehovsky
MichalStrehovsky approved these changes Oct 14, 2021
View reviewed changes
Copy link
Owner

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A unit test would be nice, but let's not block on it.

@mateoatr mateoatr self-assigned this Oct 14, 2021
@mateoatr
Copy link
Collaborator Author

Looks great! A unit test would be nice, but let's not block on it.

I just added a test, PTAL. Merging for now to unblock anyone who may need this.

@mateoatr mateoatr merged commit 39fbd92 into MichalStrehovsky:iltrim Oct 14, 2021
@MichalStrehovsky MichalStrehovsky deleted the exceptions branch October 14, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

@vitek-karas vitek-karas Awaiting requested review from vitek-karas

Assignees

@mateoatr mateoatr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for scanning exception regions
2 participants
@mateoatr @MichalStrehovsky