Generate targets in metaproj #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to access any target when building a solution. The target may or may not exist but this will create the corresponding targets in the `.metaproj`. I had to pass along the target names from the build request all the way down to the solution generator via ReadOnlyCollections. Closes dotnet#1275
AndyGerlicher
approved these changes
Dec 20, 2016
| @@ -140,6 +142,8 @@ internal class BuildRequestConfiguration : IEquatable<BuildRequestConfiguration> | |||
|
|
|||
| #endregion | |||
|
|
|||
| internal IReadOnlyCollection<string> TargetNames { get; } | |||
There was a problem hiding this comment.
This could probably use a doc comment.
|
@cdmihai Please review |
cdmihai
reviewed
Dec 20, 2016
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| using System; | |||
| using System.Collections.Generic; | |||
| using System.Collections.ObjectModel; | |||
cdmihai
reviewed
Dec 20, 2016
| @@ -104,6 +112,11 @@ internal class SolutionProjectGenerator | |||
| private ILoggingService _loggingService; | |||
|
|
|||
| /// <summary> | |||
| /// The list of targets specified to use. | |||
| /// </summary> | |||
| private readonly IReadOnlyCollection<string> _targetNames = new Collection<string>(); | |||
There was a problem hiding this comment.
Is it worth instantiating this? It gets overwritten in the constructor
There was a problem hiding this comment.
cdmihai
approved these changes
Dec 20, 2016
cdmihai
approved these changes
Dec 22, 2016
cdmihai
added a commit
to cdmihai/msbuild
that referenced
this pull request
Jan 11, 2017
This reverts commit bdb4af3.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to access any target when building a solution. The target may or may not exist but this will create the corresponding targets in the
.metaproj.I had to pass along the target names from the build request all the way down to the solution generator via ReadOnlyCollections.
Closes #1275