Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution targets need to be dynamic or at least extensible #1275

Closed
nguerrera opened this issue Oct 27, 2016 · 1 comment
Closed

Solution targets need to be dynamic or at least extensible #1275

nguerrera opened this issue Oct 27, 2016 · 1 comment
Assignees
@jeffkl
Labels
triaged
Milestone
Visual Studio 15 RTW

Comments

@nguerrera
Copy link
Contributor

There's currently a fixed set of targets emitted to the sln metaproj:

https://github.com/Microsoft/msbuild/blob/2db4d4b6821ff65987b2843d29cc5f02c4db59f5/src/XMakeBuildEngine/Construction/Solution/SolutionProjectGenerator.cs#L765-L769 (edited)

We will be needing other targets such as "pack" and "test" to work on solutions.

@jeffkl suggested "It might be as simple as taking the target you specified at the command-line and injecting it into the generated project"
@jeffkl jeffkl added this to the Visual Studio 15 RTM milestone Oct 27, 2016
@blackdwarf blackdwarf mentioned this issue Oct 27, 2016
Closed
@jeffkl jeffkl self-assigned this Nov 21, 2016
@jeffkl
Copy link
Contributor

jeffkl commented Dec 12, 2016

Should I formalize my prototype and get this ready for RTM?

jeffkl@b687fa6

jeffkl added a commit to jeffkl/msbuild that referenced this issue Dec 19, 2016
@jeffkl
Generate targets in metaproj
de56806 
This allows users to access any target when building a solution.  The target may or may not exist but this will create the corresponding targets in the `.metaproj`.

Closes dotnet#1275
jeffkl added a commit to jeffkl/msbuild that referenced this issue Dec 19, 2016
@jeffkl
Generate targets in metaproj
c124826 
This allows users to access any target when building a solution.  The target may or may not exist but this will create the corresponding targets in the `.metaproj`.

I had to pass along the target names from the build request all the way down to the solution generator via ReadOnlyCollections.

Closes dotnet#1275
jeffkl added a commit to jeffkl/msbuild that referenced this issue Dec 19, 2016
@jeffkl
Generate targets in metaproj
88b02c1 
This allows users to access any target when building a solution.  The target may or may not exist but this will create the corresponding targets in the `.metaproj`.

I had to pass along the target names from the build request all the way down to the solution generator via ReadOnlyCollections.

Closes dotnet#1275
@jeffkl jeffkl mentioned this issue Dec 19, 2016
Merged
jeffkl added a commit that referenced this issue Jan 3, 2017
@jeffkl
Generate targets in metaproj (#1497)
bdb4af3 
* Generate targets in metaproj

This allows users to access any target when building a solution.  The target may or may not exist but this will create the corresponding targets in the `.metaproj`.

I had to pass along the target names from the build request all the way down to the solution generator via ReadOnlyCollections.

Closes #1275

Might be related to #1494
@rainersigwald rainersigwald mentioned this issue Jan 13, 2017
Merged
@rainersigwald rainersigwald mentioned this issue Sep 4, 2019
Closed
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
triaged
Projects
None yet
Milestone
Visual Studio 15 RTW
Development

No branches or pull requests
4 participants
@nguerrera @jeffkl @Sarabeth-Jaffe-Microsoft @AR-May