Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing out new targets' interaction with solution (SLN) files #336

Closed
blackdwarf opened this issue Oct 27, 2016 · 4 comments
Closed

Testing out new targets' interaction with solution (SLN) files #336

blackdwarf opened this issue Oct 27, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@blackdwarf
Copy link

We are creating a new set of targets as part of this repo and overall move to MSBuild. We need to make sure that all of the new core targets work properly with SLN files. That means that for targets that do test, pack, publish, restore we need to make sure that they work properly with SLN files.

Some careful consideration needs to be done for run. At this point, I would say that run is the one command that does not work on SLN files and that requires a single project to be present.

This is related to dotnet/msbuild#1275.

/cc @nguerrera @srivatsn @piotrpMSFT @jeffkl @rainersigwald

@blackdwarf blackdwarf added this to the 1.0 RC milestone Oct 27, 2016
@rainersigwald
Copy link
Member

Note that if we do dotnet/msbuild#1275 by accepting any target there's not much we could do about run being hard to define at the solution level.

@nguerrera
Copy link
Contributor

Does run even have a corresponding msbuild target?

@TheRealPiotrP
Copy link
Contributor

no. run invokes some target that generates a PSI for it, but msbuild doesn't actually invoke

@blackdwarf
Copy link
Author

My comment about run was more in the spirit of completeness and exact speccing. :)

@srivatsn srivatsn added the Bug label Nov 10, 2016
@srivatsn srivatsn modified the milestones: 1.0 RC2, 1.0 RC3 Nov 29, 2016
@srivatsn srivatsn modified the milestones: 1.0 RC3, 1.0 RTM Jan 11, 2017
@srivatsn srivatsn modified the milestones: 1.1, 1.0 RTM Jan 27, 2017
@dsplaisted dsplaisted modified the milestones: 2.0, 1.1 May 15, 2017
@livarcocc livarcocc modified the milestones: 2.1.0, 2.0.0, 2.2.0 May 22, 2017
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants