Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests do not support multi-root workspaces #4268

Closed
2 tasks
DonJayamanne opened this issue Feb 4, 2019 · 5 comments
Closed
2 tasks

Tests do not support multi-root workspaces #4268

DonJayamanne opened this issue Feb 4, 2019 · 5 comments
Assignees
Labels
area-testing bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority

Comments

@DonJayamanne
Copy link

DonJayamanne commented Feb 4, 2019

  • Ensure Test Explorer also supports multiple folders (already supported)
  • Fix rest of code (3 files).
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug area-testing important Issue identified as high-priority labels Feb 4, 2019
@qubitron qubitron added this to the 2019, week 9 - Feb Sprint 5 milestone Feb 26, 2019
@DonJayamanne DonJayamanne changed the title Tests do not support multi-root support Tests do not support multi-root workspaces Feb 27, 2019
@brettcannon brettcannon removed this from the 2019, week 9 - Feb Sprint 5 milestone Feb 28, 2019
@DonJayamanne DonJayamanne added needs proposal Need to make some design decisions and removed needs PR labels Mar 5, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Mar 5, 2019

  • How is the test explorer meant to behave (i.e. whats the UX)?
  • Suggestion:
    • Add a folder icon with tooltip Select Folder to the top of the explorer to change/pick the folder
    • Clicking this icon will display the standard VS Code dropdown list used to pick a folder from available folders in a multi-root workspace.
    • Based on the selection, we display the name of the selected folder as a root node in the tree view.
    • Default is to always display the first folder

@DonJayamanne DonJayamanne self-assigned this Mar 6, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Mar 6, 2019

Prescribed solution

  • Add a folder icon to the toolbar
  • Clicking this new icon will display standard VSC workspace picker , then refresh explorer
  • By default display test explorer for first workspace
  • Existing commands will need to display workspace picker prompt
    • Run All Tests, Discover Test, etc....

@DonJayamanne
Copy link
Author

multiroot-tests

@ericsnowcurrently @d3r3kk
Thanks for the suggestion guys..

@qubitron Here's another approach for the test explorer and multiroot.

  • No changes to single root workspace
  • Extension already supports multi-root workspaces, just the test explorer doesn't
  • When you use any command related to testing, you'll be prompted to select a workspace folder (existing functionality).
  • Test Explorer:
    • As and when tests are discovered the test explorer will be displayed (existing functionality)
    • However, the root node in the tree view will contain the name of the workspace folder
    • Clicking on any icons on the test explorer will prompt user to select workspace folder (this happens because the icons are wired to use existing commands in command palette)
    • If you click on discover icon and select another folder and tests are discovered, then another node will be added to the test explorer containing the name of that corresponding workspace folder
    • I.e. as and when tests are discovered, the tree view will dynamically add nodes for each workspace with tests.

Suggestions

  • Add hover icons for the test folder node for Run All Tests, Debug All Tests, Discover Tests.
  • This is a single click, as opposed to clicking icons on toolbar, wher user will be prompted to select a workspace folder.

@qubitron
Copy link

qubitron commented Mar 7, 2019

@DonJayamanne your suggestion sounds good to me

@karrtikr
Copy link

validated

@ghost ghost removed the needs proposal Need to make some design decisions label Mar 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

4 participants