Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-workspace folders in test explorer #4709

Merged
merged 10 commits into from
Mar 12, 2019

Conversation

DonJayamanne
Copy link

For #4268

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #4709 into master will increase coverage by 1%.
The diff coverage is 62%.

@@          Coverage Diff           @@
##           master   #4709   +/-   ##
======================================
+ Coverage      77%     77%   +1%     
======================================
  Files         447     447           
  Lines       21454   21472   +18     
  Branches     3523    3527    +4     
======================================
+ Hits        16424   16441   +17     
- Misses       5026    5027    +1     
  Partials        4       4
Flag Coverage Δ
#Linux 66% <53%> (+1%) ⬆️
#Windows 66% <53%> (+1%) ⬆️
#macOS 66% <53%> (+1%) ⬆️

@karrtikr karrtikr self-assigned this Mar 11, 2019
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting that adding a new workspace folder, should autoDiscover tests for the new folder. It's not happening right now, is it the right behavior?

package.json Show resolved Hide resolved
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments.

@DonJayamanne DonJayamanne merged commit e28d148 into microsoft:master Mar 12, 2019
@DonJayamanne DonJayamanne deleted the issue4268Explorer branch May 24, 2019 20:25
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants