Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap: add a alwaysShowViewport setting #21784

Closed
SteveVanOpstal opened this issue Mar 2, 2017 · 14 comments
Closed

Minimap: add a alwaysShowViewport setting #21784

SteveVanOpstal opened this issue Mar 2, 2017 · 14 comments
Assignees
Labels
editor-minimap Code/Text minimap widget issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@SteveVanOpstal
Copy link

  • VSCode Version: 1.10.1
  • OS Version: Windows 10

Currently the user is required to hover over the minimap to see the viewport.
A setting which keeps the viewport visible at all time would greatly improve my minimap experience. Something like:

"editor.minimap.alwaysShowViewport": true
@junosuarez
Copy link

related #21810

@alexdima alexdima added editor-minimap Code/Text minimap widget issues feature-request Request for new features or functionality labels Mar 6, 2017
@alexdima alexdima added this to the March 2017 milestone Mar 7, 2017
@Tekbr
Copy link

Tekbr commented Mar 8, 2017

@alexandrudima I added this gif to illustrate the two situations in #21823

Allow a rectangular shadow to indicate where the minimap is, without having to move the mouse. Like Atom.

And when it slides horizontally, another shadow will be shown to indicate that I'm going to the side. Like Atom.

@mdimai666
Copy link

Change file
C:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\electron-browser\workbench.main.css

.minimap-slider{opacity:0 --> .minimap-slider{opacity:1

for highlight always

@rebornix rebornix modified the milestones: March 2017, April 2017 Mar 28, 2017
@alexdima alexdima modified the milestones: April 2017, Backlog Apr 27, 2017
@deltaidea
Copy link

Is anyone working on this?
If not, I really want this feature and would like to try to implement this.

@rebornix
Copy link
Member

@deltaidea we didn't start on this yet. You can go ahead :)

@alexdima alexdima modified the milestones: On Deck, Backlog Jun 7, 2017
@alexdima alexdima modified the milestones: June 2017, On Deck Jun 7, 2017
@alexdima
Copy link
Member

alexdima commented Jun 7, 2017

"editor.minimap.showSlider": "always" -- will come out with June stable (~1 month) or on the Insiders (~2-3 days)

@Tekbr
Copy link

Tekbr commented Jun 9, 2017

@alexandrudima How to activate horizontally? The same is not working for me, as in Atom. I put a sample gif in this comment.

@alexdima
Copy link
Member

@Tekbr I've extracted the horizontal scroll indicator in the minimap slider to #28498

@Tekbr
Copy link

Tekbr commented Jun 12, 2017

-- Sorry for the English, I used Google Translator --

All right, @alexandrudima . You are doing a job, but I believe that the suggestion I have made has significant votes. 👍

Note: I want to make it clear that horizantal does not need to be done right away.


Sorry for the outburst. 🤔 😊

@alexandrudima
A new case would be to row again ⛵️ to win the votes. (Since the comment already has votes.) Why not leave the case open and say when to check "Check only the first comment (or situation 'X')." You always create a new case for testing yourself, just reference the first comment or say what it is to verify.

You may argue, "It's better to track." But the first criterion for you in the vast majority is always number of votes for a new resource, and it would be difficult, in certain moments to get the votes again.

I had created another question before, you marked it as duplicate, so you think it will come all at once. Well many question, in some question there is comment similar to this.: "We will expose the ideas in a single case - because it is better to track."

It was much better for you to have changed the title of the first question and to inform me thus "Here only the horizontal resource will be traced."

Then you say that it is for us to look up the questions before creating a new one (ps: yes, not many suggestive names in the questions until you change them - or the difference of language in my case), but when we suggest something Get votes on this question) you ask to create a new one (or in the case we already created it and it was marked as duplicate and we have to create it again.)

You better review the way you deal with these situations, in my opinion.

NOTE: This does not include when there is OS difference.

One more excuse for the outburst. 😊 😊

I may even be denied the comment or be hated, but I had to write it this.

@magic890
Copy link

@alexandrudima ok, close this one but you also close the other one. So no open issue for this feature. When it will be implemented?

@deltaidea
Copy link

@magic890 It's already implemented. It's currently available on the Insiders channel. It'll get into the stable release in a couple weeks I think.

@alexdima
Copy link
Member

@Tekbr I just implemented the horizontal scrolling in #28498 .

Please consider contributing PRs if you feel very passionate about a certain feature request.

@Tekbr
Copy link

Tekbr commented Jun 21, 2017

-- Sorry for the English, I used Google Translator --

Yes, @alexandrudima , but I would be happy to contribute. But I have better enough my English, being that is something main here. In addition to having a longer time to study TypeScript.

Anyway, thank you very much for implementing the feature. ❤️ ❤️ 👏 👏 👏

But my argument is valid since it was previously marked as a duplicate, and since you ask for a single issue to be tracked, to make it easier, it will soon be interpreted that everything will be done in a single question. That's why I was a little upset.

But everything was solved. Thank you one more time. ❤️ ❤️ 👏 👏 👏

@alexdima alexdima added the verification-needed Verification of issue is requested label Jun 27, 2017
@weinand weinand added the verified Verification succeeded label Jun 28, 2017
@weinand
Copy link
Contributor

weinand commented Jun 28, 2017

Verified that the new setting "editor.minimap.showSlider": "always" works as suggested in this issue.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-minimap Code/Text minimap widget issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

9 participants