-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Minimap position highlight #21404
Comments
I think 3 is the one I mostly use - so easy to find or find and replace when you can see the highlights in the minimap - as long as they are very visible (strong contrast) - in atom and sublime the highlights are not nearly as visible as they should be, it's too easy to miss them in the syntax colors... |
if minimap is enabled AND with the behavior fixed as @ghiscoding suggested, we don't need that slim default bar, minimap replaces it |
I would like it when the current line is also highlighted in the minimap. |
I'm very surprised there is no highlight on minimap - guess will STILL stick with atom.io for now. |
Request 3 is a feature that exists in Atom, at least via third-party packages. In my opinion, that is very much needed and without that the utility of the minimap is questionable at best. Hopefully they will implement this feature soon. In the meantime, I'll still be sticking with VScode instead of atom as I totally love the git integration in VScode, including the diff feature and due to the search feature being in the sidebar rather than editor window. |
I quickly hacked together a rudimentary implementation of Request 1 and 3 at abhijitvalluri@a1f2d2f For request 3, I couldn't yet figure out how to highlight just the precise token corresponding to the word that is highlighted. So, instead I decided to highlight the entire line. In my opinion, this is probably a bit better as it is easier to see the whole line light up instead of just the word, which will be much smaller and harder to spot. You could take that code, modify it and make your own custom version of vscode. And if you can make it nicer still go ahead and send in a PR! |
Made some improvements to the minimap highlight implementation: https://github.com/abhijitvalluri/vscode/commits/minimap_enhancements Right now, all the implementation details are hardcoded, including it being set up for a dark theme. Also, there is a bug wherein if the file is too large, so that the minimap scrolls and does not fit entirely in one view, then only highlights for the portion of the file that is visible in the minimap works. Once you scroll, there are no highlights for the invisible part of the file in the minimap. UPDATE: If you don't mind this hardcoded feature, and are fine with the dark theme, then you can make a packaged version of this by running:
And then you will have your very own vscode with highlighting in the minimap. This is good enough for me, for now! So I am using this as my default version of vscode! 🤓 |
@alexandrudima do you think it would be possible to use/merge the code provided by @abhijitvalluri for the number 3. that I have in the list
|
My code may not be in a good shape for merging. So, I can clean it up if needed so that these changes can be made use of in vscode! Do let me know. |
The number (1) from the list has now been implemented Minimap: add a |
+1 would like to get Request #3 implemented. Migrated from Atom and finding it horribly inefficient to hav no word highlighting in the minimap. |
Is there already a ticket for the minimap word highlights? I've seen it mentioned in a few tickets but it was always mixed with other things for the minimap. |
I need this too |
Unfortunately, minimap seems to be very low on the priority list (if not forgotten). |
Tweeted to Visual Code and we need a bigger push for this feature just fyi |
Someone needs to make a case to the big wigs, because it honestly will improve aggregate employee effectiveness over a known interval of time because all you have to do is double click words and look at the minimap to see if further action is needed. This increases maximum potential actions over the known interval by minimizing mental and physical boilerplate associated with finding or confirming keyword instances without using the minimap. It is an inversely proportionate relationship. As time spent analyzing increases, file changes per second decreases. Multiply this by the number of Microsoft employees and the cost-benefit ratio warrants the potential gain in sprint velocity. This upgrade saves unnecessary trips to CTRL+F to iterate through results, and allows you to confirm if keyword placements are present or missing at known locations in the file with an average time-to-completion of 0.5 to 2 seconds with minimap and 5 to 10 seconds with CTRL+F. |
Thanks @agm1984. Hopefully, more people will tweet/comment for this feature to make it to next release. Honestly, this is the one feature that keeps me from using VScode as my sole editor, double clicking on a word and seeing it sprinkled throughout the minimap is an amazing thing :) |
By the way, I recently looked into rebasing my above hack to enable highlighting for newer builds of vscode. Sadly however, it looks like the underlying code changed by quite a bit and I have not figured out how to redo the same changes on the latest code base. But if it was doable then, it should be doable now, and it OUGHT to be doable by the vscode devs. |
If the Vote for popular feature requests listing is any indication of how the team prioritize their work then we have much to lament. This issue in particular is currently on the 3rd page, behind popular requests such as Offline spell checker, Transparent window and A portable version of the app. |
How is a transparent window more important than this!!? Sheesh, people want eye-candy more than actual features that are useful for productivity! :( |
I'm still using Atom even though is painfully slow sometimes, just because I'm so used to minimap highlighting, it saves me a lot of time for analyzing code. Really cant believe that such a basic feature is still not implemented. |
@zemzela I'm doing the same thing. I have Atom open and basically using it as my main editor until I need to use the awesome debugger in VS Code. Hopefully if we keep the conversation going on this topic the good peeps at VS Code will give us this much needed feature. Maybe re/tweet them more to show that the community cares about this feature. |
This feature would be incredibly useful for me as I work in Haskell and it's really difficult in large files to find all the references. Also, I've heard and seen some people talk about combining the thin scroll bar with the minimap scrollbar, and I think that is a great idea. There is currently a little bit of mismatch between the two and it would be great to unify them. |
This feature is super useful when Cmd-D selecting multiple occurences of a word that is scattered across a longer file. Coming from Atom I really miss it in VSCode. |
Looking forward to seeing this in vscode. Just switched over from Sublime and really missing this feature. |
@katespaghetti |
Is this feature out yet? |
I'd like to see the minimap have all the highlighting features of the scrollbar to replace the scrollbar completely. It feels strange and unnecessary to have two scrollbars for the same window. |
I've added a comment in next June 2019 Iteration Plan, you guys can up vote there as well if you wish. |
Here is a link to comment to vote: #75103 (comment) |
So....The new version came out. It....sort of has this feature we have been waiting for for 2.5 years. A couple problems:
Any chance these can be fixed in less time than 2.5 years? These seem like pretty simple changes to make. |
Our wishes might have been heard...
that was pulled from July Iteration Plan (2019), it does sound like this ticket 🤞 EDIT Unfortunately, they are actually different issues with similar subject title. I'm afraid that our issue will not be addressed at this time. Sad to see that it takes years to look into this 😿 |
With the release of 1.37.0 we kind of have that feature now. The only downside is that it doesn't work on simple selections, but on searches only. That means you need to doubleclick first, and press CTRL+F afterwards... We are almost there. Is there a way to automate searching for the selection? |
I tried to talk about it in #78807 along another issue which is assigned to the person who implemented the feature for the search selection. Wait and see |
Hey all! I did the work on search results in the minimap, which was the first step of enabling decorations in the minimap. This was meant to be the foundation for further decoration improvements to the minimap. I'm not working on this in the current iteration, but this issue is on my radar! |
@RMacfarlane |
I've just checked in the change for showing selection decorations in the minimap, it will be available in tomorrow's VSCode Insiders if you want to try it out early, otherwise in our next stable release in October. |
@RMacfarlane Note that I proposed 3 enhancements and now 2/3 are done, we are still missing the "Show Color in Minimap" but it was not as high interested as the other 2 were. You close the issue but I wonder if that would be doable in the future? Should that be a separate issue? |
@ghiscoding Can you open a separate issue to track that? |
I have some enhancement requests for the current minimap implementation which are already available in
Atom
as separate plugins.alwaysShowViewport
setting #21784. A new flag was added"editor.minimap.showSlider": "always"
(its default is however set tomouseover
)Atom
as a separate pluginminimap-pigments
which I find very convenient.Sublime Text
and has a white background (instead of grey)... see print screen.The text was updated successfully, but these errors were encountered: