-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GD-76: Fix SceneRunner to propagate input events in the right way #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * GD-351: Fix SceneRunner to propagate input events in the right order The Scene Runner did not work correctly, e.g. _gui_input() was never called - Revised the handling of input events to ensure that all input events are sent correctly. - Added Input to store the current input event so that it can be accessed via Input.is_... accessible. - Drag&Drop test case added - Improved testing of input events - Reset press state to inital state when Scene Runner is released.
…e event direct to the viewport - check is running on headless mode and skip tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The Scene Runner did not work correctly, e.g. _gui_input() was never called
What
Additional Info
I ask for a solution here: godotengine/godot#73557