Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for bionic and stretch [compatible] #13657

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Remove support for bionic and stretch [compatible] #13657

merged 1 commit into from
Jul 19, 2023

Conversation

dkijania
Copy link
Member

Explain your changes:
Removes support for bionic and stretch dockers alike to berkeley and develop

Explain how you tested your changes:
Running CI

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@dkijania dkijania self-assigned this Jul 19, 2023
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania marked this pull request as ready for review July 19, 2023 11:12
@dkijania dkijania requested a review from a team as a code owner July 19, 2023 11:12
shimkiv
shimkiv approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@shimkiv shimkiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor one:

@dkijania dkijania merged commit cd1986b into compatible Jul 19, 2023
@dkijania dkijania deleted the remove_support_for_bionic_and_stretch branch July 19, 2023 12:28
@dkijania
Copy link
Member Author

Ok, will talk with Steven about that, maybe we would like to revert support

@stevenplatt stevenplatt mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimkiv shimkiv shimkiv approved these changes

Assignees

@dkijania dkijania

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkijania @shimkiv