Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate lookup tables #14566

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Deduplicate lookup tables #14566

merged 1 commit into from
Nov 16, 2023

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Nov 16, 2023 •
edited
Loading

#14405 (comment) for o1js

@mitschabaude mitschabaude marked this pull request as ready for review November 16, 2023 15:07
@mitschabaude mitschabaude requested a review from a team as a code owner November 16, 2023 15:07
@mitschabaude
Copy link
Contributor Author

!ci-build-me

@dannywillems
Copy link
Member

dannywillems commented Nov 16, 2023 •
edited
Loading

A test in https://github.com/MinaProtocol/mina/blob/f60f1f4ec709f4f1f1f57ddb3ce75844f5d9f88c/src/lib/pickles/test/optional_custom_gates/test_fix_domains.ml would be very welcome! :). If you don't write it, please open a follow-up issue.

dannywillems
dannywillems approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about test!

@dannywillems dannywillems mentioned this pull request Nov 16, 2023
Closed
@dannywillems dannywillems merged commit 5ea4bd1 into o1js-main Nov 16, 2023
1 of 2 checks passed
@dannywillems dannywillems deleted the fix/lookup-tables branch November 16, 2023 18:13
This was referenced Nov 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannywillems dannywillems dannywillems approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitschabaude @dannywillems @mrmr1993