Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate lookup tables #14566

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Deduplicate lookup tables #14566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/crypto/proof-systems
Open in desktop
Submodule proof-systems updated 2 files
+13 −2 kimchi/src/circuits/constraints.rs
+47 −0 kimchi/src/circuits/lookup/tables/mod.rs
7 changes: 2 additions & 5 deletions src/lib/pickles/fix_domains.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,11 @@ let domains (type field gates) ?feature_flags
feature_flags
in
let combined_lookup_table_length =
let range_check_table_used = range_check0 || range_check1 || rot in
let range_check_table_used_again =
(* FIXME: This is a hack around a bug in proof-systems. *)
foreign_field_mul
let range_check_table_used =
range_check0 || range_check1 || foreign_field_mul || rot
in
let xor_table_used = xor in
(if range_check_table_used then Int.pow 2 12 else 0)
+ (if range_check_table_used_again then Int.pow 2 12 else 0)
+ (if xor_table_used then Int.pow 2 8 else 0)
+ ( if lookup then (
Kimchi_backend_common.Plonk_constraint_system
Expand Down
Loading