Hybrid tokenizers #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pringled
approved these changes
Sep 25, 2024
model2vec/distill/distillation.py
Outdated
| :param device: The device to use. | ||
| :param pca_dims: The number of components to use for PCA. If this is None, we don't apply PCA. | ||
| :param apply_zipf: Whether to apply Zipf weighting to the embeddings. | ||
| :param use_subword: Whether to keep subword tokens in the vocabulary. If this is False, you must pass a vocabulary. |
There was a problem hiding this comment.
This also changes the actual tokenizer from subword to word level right? I would also specify that in the description
model2vec/distill/distillation.py
Outdated
| :param use_subword: Whether to keep subword tokens in the vocabulary. If this is False, you must pass a vocabulary. | ||
| :raises: ValueError if the PCA dimension is larger than the number of dimensions in the embeddings. | ||
| :raises: ValueError if the vocabulary contains duplicate tokens. | ||
| :return: A StaticModdel |
There was a problem hiding this comment.
Suggested change
| :return: A StaticModdel | |
| :return: A StaticModel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.