Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NetworkTime.localTime/.time is now frame time #2838

Closed
wants to merge 1 commit into from
Closed

feat: NetworkTime.localTime/.time is now frame time #2838

wants to merge 1 commit into from

Conversation

imerr
Copy link
Contributor

@imerr imerr commented Jul 16, 2021

This is for consistency, a frame is should be simulated for a fixed point in time, no matter how long simulation takes
This mirrors how Time.time works

@imerr
feat: NetworkTime.localTime/.time is now frame time
a0ac1a9 
This is for consistency, a frame is should be simulated for a fixed point in time, no matter how long simulation takes
This mirrors how Time.time works
This was referenced Jul 16, 2021
Merged
Closed
Closed
@MrGadget1024 MrGadget1024 requested a review from miwarnec July 30, 2021 14:20
@MrGadget1024 MrGadget1024 added Awaiting Review enhancement New feature or request labels Jul 30, 2021
@miwarnec
Copy link
Collaborator

definitely useful.
2020.3 LTS has been out for a while, which as double frame time.
let's just use that instead of worrying about doing it ourselves.
it's august, so not too long until we upgrade anyway.
anyone who needs double time today, can safely upgrade to 2020.3 already.

@miwarnec miwarnec closed this Aug 13, 2021
imerr added a commit that referenced this pull request Oct 6, 2023
@imerr
NetworkTime creates it's own frame time in 2019
59cda4b 
Since we don't have double time there yet and the stopwatch will change during the frame which causes jitter and other artifacts
supersedes #3623
See also #2838
imerr added a commit that referenced this pull request Oct 6, 2023
@imerr
fix: NetworkTime creates it's own frame time in 2019
3b8a26e 
Since we don't have double time there yet and the stopwatch will change during the frame which causes jitter and other artifacts
supersedes #3623
See also #2838
@imerr imerr mentioned this pull request Oct 8, 2023
Merged
imerr added a commit that referenced this pull request Oct 8, 2023
@imerr
fix: NetworkTime creates it's own frame time in 2019
0c9e72b 
Since we don't have double time there yet and the stopwatch will change during the frame which causes jitter and other artifacts
supersedes #3623
See also #2838
miwarnec pushed a commit that referenced this pull request Oct 8, 2023
@imerr
fix: NetworkTime creates it's own frame time in 2019 (#3624)
0c5eba7 
Since we don't have double time there yet and the stopwatch will change during the frame which causes jitter and other artifacts
supersedes #3623
See also #2838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miwarnec miwarnec Awaiting requested review from miwarnec

Assignees
No one assigned
Labels
Awaiting Review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imerr @miwarnec @MrGadget1024