Fix authority property in NetworkBehaviour while in host mode #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixed, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3528.
Fixes #3529.
Closes #3530.
This fix changes behaviour of
NetworkBehaviour.authorityproperty to return true while you are host and has authority over object.If server and syncDirection is ServerToClient - return true, otherwise false.
If client and syncDirection is ClientToServer and object is owned - return true, otherwise false.
This condition is more readable than the old one and is still fast.
Still there an possible usage error while on the server you are trying to use
OnStartAuthorityorOnStopAuthoritysince you have anauthority. To fix this we need to allow usage ofOnStartAuthorityandOnStartAuthorityon server. Maybe it is related to #3495.