Merged
Conversation
추가로 각각 질문과 지원서의 제한 길이를 증가시켰습니다
추가로 각각 질문과 지원서의 제한 길이를 증가시켰습니다
Contributor
|
""" Walkthrough신규 Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Controller
participant ClubApplyService
participant ClubQuestion(Entity)
Client->>Controller: 지원서 생성/수정 요청(title, description, questions)
Controller->>ClubApplyService: create/editClubApplication(request)
ClubApplyService->>ClubQuestion: updateFormTitle(request.title)
ClubApplyService->>ClubQuestion: updateFormDescription(request.description)
ClubApplyService->>ClubQuestion: updateQuestions(request.questions)
ClubApplyService->>Controller: 완료 응답
Controller->>Client: 결과 반환
sequenceDiagram
participant Client
participant Controller
participant ClubApplyService
participant ClubQuestion(Entity)
Client->>Controller: 지원서 조회 요청
Controller->>ClubApplyService: getClubApplication()
ClubApplyService->>ClubQuestion: getTitle(), getDescription(), getQuestions()
ClubApplyService->>Controller: ClubApplicationResponse(title, description, questions)
Controller->>Client: 지원서 데이터 반환
Possibly related issues
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Test Results75 tests 66 ✅ 1s ⏱️ For more details on these failures, see this check. Results for commit 27a7da2. ♻️ This comment has been updated with latest results. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
backend/src/main/java/moadong/club/service/ClubApplyService.java (1)
23-23: 명시적 import 사용을 권장합니다.와일드카드 import (
java.util.*) 대신 사용되는 클래스들을 명시적으로 import하는 것이 좋습니다. 명시적 import는 코드 가독성을 높이고 네이밍 충돌을 방지합니다.-import java.util.*; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
backend/src/main/java/moadong/club/entity/ClubQuestion.java(2 hunks)backend/src/main/java/moadong/club/payload/request/ClubApplicationCreateRequest.java(1 hunks)backend/src/main/java/moadong/club/payload/request/ClubApplicationEditRequest.java(1 hunks)backend/src/main/java/moadong/club/payload/request/ClubApplyQuestion.java(2 hunks)backend/src/main/java/moadong/club/payload/response/ClubApplicationResponse.java(1 hunks)backend/src/main/java/moadong/club/service/ClubApplyService.java(4 hunks)
🧰 Additional context used
🧠 Learnings (6)
backend/src/main/java/moadong/club/payload/response/ClubApplicationResponse.java (2)
Learnt from: lepitaaar
PR: Moadong/moadong#406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.
Learnt from: Zepelown
PR: Moadong/moadong#406
File: backend/src/main/java/moadong/club/entity/ClubApplicationQuestion.java:32-33
Timestamp: 2025-05-15T12:03:57.356Z
Learning: 엔티티 클래스는 요청/응답 객체(DTO)에 의존해서는 안 됩니다. 계층 간 의존성 문제를 방지하기 위해 엔티티와 DTO는 분리되어야 합니다. 예를 들어, `ClubApplicationQuestion` 엔티티가 `ClubApplicationRequest.Options`와 같은 요청 객체를 직접 참조하는 대신, 엔티티 패키지 내에 `QuestionOptions`와 같은 별도의 클래스를 정의하고 사용해야 합니다. 이렇게 하면 요청 객체 변경이 데이터베이스 스키마나 엔티티 계층에 영향을 미치지 않습니다.
backend/src/main/java/moadong/club/payload/request/ClubApplyQuestion.java (1)
Learnt from: lepitaaar
PR: Moadong/moadong#406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.
backend/src/main/java/moadong/club/payload/request/ClubApplicationCreateRequest.java (1)
Learnt from: lepitaaar
PR: Moadong/moadong#406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.
backend/src/main/java/moadong/club/entity/ClubQuestion.java (1)
Learnt from: lepitaaar
PR: Moadong/moadong#406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.
backend/src/main/java/moadong/club/payload/request/ClubApplicationEditRequest.java (1)
Learnt from: lepitaaar
PR: Moadong/moadong#406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.
backend/src/main/java/moadong/club/service/ClubApplyService.java (2)
Learnt from: lepitaaar
PR: Moadong/moadong#406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.
Learnt from: Zepelown
PR: Moadong/moadong#406
File: backend/src/main/java/moadong/club/entity/ClubApplicationQuestion.java:32-33
Timestamp: 2025-05-15T12:03:57.356Z
Learning: 엔티티 클래스는 요청/응답 객체(DTO)에 의존해서는 안 됩니다. 계층 간 의존성 문제를 방지하기 위해 엔티티와 DTO는 분리되어야 합니다. 예를 들어, `ClubApplicationQuestion` 엔티티가 `ClubApplicationRequest.Options`와 같은 요청 객체를 직접 참조하는 대신, 엔티티 패키지 내에 `QuestionOptions`와 같은 별도의 클래스를 정의하고 사용해야 합니다. 이렇게 하면 요청 객체 변경이 데이터베이스 스키마나 엔티티 계층에 영향을 미치지 않습니다.
🔇 Additional comments (12)
backend/src/main/java/moadong/club/entity/ClubQuestion.java (1)
48-50: updateFormDescription 메서드 구현이 적절합니다기존
updateFormTitle메서드와 일관된 패턴으로 잘 구현되었습니다.backend/src/main/java/moadong/club/payload/response/ClubApplicationResponse.java (1)
11-11: 응답 DTO에 description 필드 추가가 적절합니다필드 배치가 논리적이고(title, description, questions 순서) 요청 DTO들과 일관성을 유지하고 있습니다.
backend/src/main/java/moadong/club/payload/request/ClubApplyQuestion.java (2)
16-16: 질문 제목 길이 제한 확장이 적절합니다20자에서 200자로 확장하여 더 상세한 질문 제목을 작성할 수 있게 되었습니다. 기존 제한이 너무 제한적이었으므로 개선된 변경사항입니다.
35-35: 질문 항목 값 길이 제한 확장이 적절합니다QuestionItem의 value 필드도 20자에서 200자로 확장하여 질문 제목과 일관성을 유지하고 있습니다.
backend/src/main/java/moadong/club/payload/request/ClubApplicationCreateRequest.java (2)
12-12: 제목 길이 제한 확장이 적절합니다20자에서 50자로 확장하여 더 의미 있는 제목을 작성할 수 있게 되었습니다.
15-17: description 필드 추가가 잘 구현되었습니다
@NotBlank와@Size(max = 500)검증이 적절하게 설정되어 있고, 요청 시 설명을 필수로 입력받도록 하는 것이 합리적입니다.backend/src/main/java/moadong/club/payload/request/ClubApplicationEditRequest.java (2)
12-12: 제목 길이 제한이 생성 요청과 일관되게 확장되었습니다ClubApplicationCreateRequest와 동일하게 50자로 설정하여 일관성을 유지하고 있습니다.
15-17: description 필드가 생성 요청과 일관되게 구현되었습니다ClubApplicationCreateRequest와 동일한 검증 규칙(
@NotBlank,@Size(max = 500))을 적용하여 생성과 수정 작업 간 일관성을 보장하고 있습니다.backend/src/main/java/moadong/club/service/ClubApplyService.java (4)
54-54: 안전한 null 처리가 잘 구현되었습니다.
Optional.ofNullable().orElse("")를 사용하여 description 필드의 null 값을 안전하게 처리하고 있습니다. 응답 객체에 항상 non-null 값을 보장하는 좋은 방어적 프로그래밍 패턴입니다.
191-191: 일관된 패턴으로 description 필드가 잘 추가되었습니다.기존
updateFormTitle호출과 동일한 패턴으로updateFormDescription을 추가하여 일관성을 유지하고 있습니다.
196-198: 기술 부채에 대한 명확한 문서화입니다.
createQuestions와updateQuestions메서드 간의 코드 중복 문제를 인지하고 향후 리팩토링 계획을 명시한 것은 좋은 접근입니다. 이전 리뷰에서도 언급된 기술 부채를 적절히 문서화하고 있습니다.
229-229: create 메서드와 일관된 구현입니다.
createQuestions메서드와 동일한 패턴으로 description 업데이트를 추가하여 생성과 수정 작업 간의 기능적 일치성을 유지하고 있습니다.
This was referenced Jul 20, 2025
Merged
oesnuj
added a commit
that referenced
this pull request
Jul 22, 2025
…ion-limit [refactor] 관리자 페이지에서 지원서 제작 시 글자 수 제한 수정
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
중점적으로 리뷰받고 싶은 부분(선택)
논의하고 싶은 부분(선택)
🫡 참고사항
Summary by CodeRabbit
신규 기능
개선 사항