Skip to content

[refactor] 지원서 길이 제한 변경#567

Merged
lepitaaar merged 1 commit intodevelop/befrom
refactor/application-length-limit-change
Jul 22, 2025
Merged

[refactor] 지원서 길이 제한 변경#567
lepitaaar merged 1 commit intodevelop/befrom
refactor/application-length-limit-change

Conversation

@lepitaaar
Copy link
Contributor

@lepitaaar lepitaaar commented Jul 22, 2025 •
edited by coderabbitai bot
Loading

#️⃣연관된 이슈

#565

📝작업 내용

지원서 설명 제한 500자 -> 3000자
지원 응답 각 30, 100 -> 100, 1000자 변경

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

  • New Features
    • 동아리 지원서 및 수정 시 설명란에 입력 가능한 최대 글자 수가 500자에서 3000자로 확대되었습니다.
    • 지원서 문항 답변 시 단답형은 최대 100자, 장문형은 최대 1000자까지 입력할 수 있도록 확장되었습니다.

@lepitaaar lepitaaar self-assigned this Jul 22, 2025
@lepitaaar lepitaaar added the 💾 BE Backend label Jul 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 22, 2025 •
edited
Loading

Walkthrough

이 변경사항은 동아리 지원 요청 및 수정 요청의 description 필드 최대 길이를 500자에서 3000자로 확장하고, 서비스 레이어에서 질문 답변의 최대 길이 제한(단문: 30→100자, 장문: 500→1000자)을 상향 조정합니다.

Changes

파일/경로 변경 요약
.../payload/request/ClubApplicationCreateRequest.java
.../payload/request/ClubApplicationEditRequest.java		 description 필드의 최대 길이 유효성 검사 제한을 500자에서 3000자로 변경
.../service/ClubApplyService.java 질문 답변(단문/장문) 최대 길이 제한을 각각 100자, 1000자로 상향 조정

Estimated code review effort

1 (~2 minutes)

Possibly related issues

Possibly related PRs

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 399aa73 and a15dfb9.

📒 Files selected for processing (3)
  • backend/src/main/java/moadong/club/payload/request/ClubApplicationCreateRequest.java (1 hunks)
  • backend/src/main/java/moadong/club/payload/request/ClubApplicationEditRequest.java (1 hunks)
  • backend/src/main/java/moadong/club/service/ClubApplyService.java (1 hunks)
🧠 Learnings (3)
backend/src/main/java/moadong/club/service/ClubApplyService.java (1)

Learnt from: lepitaaar
PR: #406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.

backend/src/main/java/moadong/club/payload/request/ClubApplicationCreateRequest.java (1)

Learnt from: lepitaaar
PR: #406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.

backend/src/main/java/moadong/club/payload/request/ClubApplicationEditRequest.java (1)

Learnt from: lepitaaar
PR: #406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.

🧰 Additional context used
🧠 Learnings (3)
backend/src/main/java/moadong/club/service/ClubApplyService.java (1)

Learnt from: lepitaaar
PR: #406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.

backend/src/main/java/moadong/club/payload/request/ClubApplicationCreateRequest.java (1)

Learnt from: lepitaaar
PR: #406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.

backend/src/main/java/moadong/club/payload/request/ClubApplicationEditRequest.java (1)

Learnt from: lepitaaar
PR: #406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.

🔇 Additional comments (8)
backend/src/main/java/moadong/club/service/ClubApplyService.java (4)

159-159: 단문 답변 길이 제한 증가가 올바르게 적용되었습니다.

SHORT_TEXT 타입 질문의 답변 길이 제한이 30자에서 100자로 적절히 증가되었습니다.

164-164: 장문 답변 길이 제한 증가가 올바르게 적용되었습니다.

LONG_TEXT 타입 질문의 답변 길이 제한이 500자에서 1000자로 적절히 증가되었습니다.

159-159: 단문 답변 길이 제한 증가 승인

SHORT_TEXT 타입의 답변 길이 제한을 30자에서 100자로 증가시킨 변경사항이 적절합니다. 사용자가 더 자세한 답변을 작성할 수 있게 되어 지원서 품질 향상에 도움이 될 것입니다.

164-164: 장문 답변 길이 제한 증가 승인

LONG_TEXT 타입의 답변 길이 제한을 500자에서 1000자로 증가시킨 변경사항이 적절합니다. 더 충실한 답변 작성이 가능해져 지원자와 동아리 간의 더 나은 매칭에 기여할 것입니다.

backend/src/main/java/moadong/club/payload/request/ClubApplicationCreateRequest.java (2)

16-16: 지원서 설명 필드 길이 제한이 올바르게 확장되었습니다.

description 필드의 최대 길이가 500자에서 3000자로 증가하여 보다 상세한 지원서 작성이 가능해졌습니다.

16-16: 동아리 지원서 생성 요청의 설명 필드 길이 제한 증가 승인

description 필드의 최대 길이를 500자에서 3000자로 증가시킨 변경사항이 적절합니다. 동아리에 대한 더 자세한 설명 작성이 가능해져 지원자들에게 더 많은 정보를 제공할 수 있습니다.

backend/src/main/java/moadong/club/payload/request/ClubApplicationEditRequest.java (2)

16-16: 지원서 수정 요청의 설명 필드 길이 제한이 일관되게 확장되었습니다.

ClubApplicationCreateRequest와 동일하게 description 필드의 최대 길이가 3000자로 증가하여 생성과 수정 시 일관된 사용자 경험을 제공합니다.

16-16: 동아리 지원서 수정 요청의 설명 필드 길이 제한 증가 승인

description 필드의 최대 길이를 500자에서 3000자로 증가시킨 변경사항이 적절합니다. ClubApplicationCreateRequest와 일관성을 유지하며, 지원서 수정 시에도 동일한 수준의 자세한 설명을 작성할 수 있습니다.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jul 22, 2025

Test Results

75 tests   75 ✅  2s ⏱️
12 suites   0 💤
12 files     0 ❌

Results for commit a15dfb9.

Zepelown
Zepelown approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@Zepelown Zepelown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@lepitaaar lepitaaar merged commit d33daa9 into develop/be Jul 22, 2025
3 checks passed
@lepitaaar lepitaaar deleted the refactor/application-length-limit-change branch September 20, 2025 01:36
@coderabbitai coderabbitai bot mentioned this pull request Dec 23, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zepelown Zepelown Zepelown approved these changes

@PororoAndFriends PororoAndFriends Awaiting requested review from PororoAndFriends

Assignees

@lepitaaar lepitaaar

Labels

💾 BE Backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lepitaaar @Zepelown

Comments