Skip to content

[release] v1.0.9#607

Merged
oesnuj merged 9 commits intomainfrom
develop-fe
Jul 28, 2025
Merged

[release] v1.0.9#607
oesnuj merged 9 commits intomainfrom
develop-fe

Conversation

@oesnuj
Copy link
Member

@oesnuj oesnuj commented Jul 28, 2025

📝작업 내용 (v1.0.9)

  • 모집 기간만으로 /application/:id로 진입하던 로직을 개선

  • 모아동 지원서 미등록 시 무한 alert 반복되는 UX 버그 수정

  • 지원서 설명 배경색 추가

동아리 지원 흐름을 아래 순서로 재구성:

  1. 모집 기간 여부 확인 (마감 시 alert)

  2. 모아동 지원서 존재 시 → 내부 지원서 페이지로 이동

  3. 외부 지원 링크 존재 시 → 새 창에서 외부 링크 이동

  4. 아무 것도 없으면 안내 메시지 출력

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

  • 신규 기능

    • 동아리 상세 정보에 외부 지원서 URL(externalApplicationUrl) 지원이 추가되었습니다.
  • 버그 수정

    • 지원 버튼 클릭 시 모집 기간을 실시간으로 확인하고, 모집이 마감된 경우 안내 메시지를 제공합니다.
    • 기존 지원 내역이 없을 경우 외부 지원서 URL이 있으면 새 탭에서 열립니다.
  • 스타일

    • 입력 필드와 텍스트 영역의 최소/최대 너비 및 패딩이 개선되어 반응형 UI가 향상되었습니다.
    • 지원서 설명 영역에 배경색, 패딩, 모서리 둥글기 스타일이 추가되었습니다.
  • 리팩터

    • 지원 버튼(ClubApplyButton)과 관련 컴포넌트의 props 구조가 간소화되었습니다.

@oesnuj oesnuj self-assigned this Jul 28, 2025
@oesnuj oesnuj added 💻 FE Frontend 📈 release 릴리즈 배포 labels Jul 28, 2025
@vercel
Copy link

vercel bot commented Jul 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
moadong ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2025 0:54am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 28, 2025

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Warning

Rate limit exceeded

@oesnuj has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 11 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5c80b50 and 3b18a3f.

📒 Files selected for processing (7)
  • frontend/src/components/common/CustomTextArea/CustomTextArea.styles.ts (1 hunks)
  • frontend/src/components/common/InputField/InputField.styles.ts (2 hunks)
  • frontend/src/pages/ApplicationFormPage/ApplicationFormPage.styles.ts (1 hunks)
  • frontend/src/pages/ClubDetailPage/components/ClubApplyButton/ClubApplyButton.tsx (2 hunks)
  • frontend/src/pages/ClubDetailPage/components/ClubDetailFooter/ClubDetailFooter.tsx (2 hunks)
  • frontend/src/pages/ClubDetailPage/components/ClubDetailHeader/ClubDetailHeader.tsx (2 hunks)
  • frontend/src/types/club.ts (1 hunks)

Walkthrough

이 변경사항은 동아리 지원 버튼(ClubApplyButton)의 모집 상태 판단 및 지원 경로 처리를 내부적으로 비동기적으로 수행하도록 리팩토링하고, 관련 컴포넌트들의 props 구조를 정리합니다. 또한, 일부 스타일 컴포넌트의 레이아웃 및 패딩을 개선하며, 동아리 상세 타입에 외부 지원 URL 속성을 추가합니다.

Changes

Cohort / File(s) Change Summary
ClubApplyButton 리팩토링 및 모집 상태 비동기 처리
frontend/src/pages/ClubDetailPage/components/ClubApplyButton/ClubApplyButton.tsx
isRecruiting prop 제거, 내부적으로 club detail을 fetch하여 모집 기간을 파싱 및 비교, 지원서 존재 여부 확인, 외부 지원 URL 처리 등 비동기 로직 도입. 버튼 클릭 시 모집 마감 여부에 따라 알림 또는 지원 경로 분기 처리. 기존 이벤트 트래킹 위치 변경.
ClubDetailFooter/ClubDetailHeader prop 구조 변경
frontend/src/pages/ClubDetailPage/components/ClubDetailFooter/ClubDetailFooter.tsx, frontend/src/pages/ClubDetailPage/components/ClubDetailHeader/ClubDetailHeader.tsx
ClubDetailFooter에서 recruitmentForm, presidentPhoneNumber prop 제거, recruitmentPeriod만 사용. ClubApplyButton에 더 이상 isRecruiting prop 전달하지 않음. ClubDetailHeader에서는 모집 기간 관련 유틸 및 prop 사용 제거, ClubApplyButton prop 관련 로직 삭제.
동아리 상세 타입 확장
frontend/src/types/club.ts
ClubDetail 인터페이스에 externalApplicationUrl?: string 속성 추가.
스타일 개선 - 입력/텍스트영역/폼 설명
frontend/src/components/common/CustomTextArea/CustomTextArea.styles.ts, frontend/src/components/common/InputField/InputField.styles.ts, frontend/src/pages/ApplicationFormPage/ApplicationFormPage.styles.ts
입력 필드, 텍스트영역의 min-width → max-width: 100%로 변경, 패딩 및 반응형 스타일 개선. 폼 설명 영역의 패딩, 배경색, border-radius 추가 및 모바일 패딩 조정.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ClubApplyButton
    participant useGetClubDetail
    participant getApplication
    participant Browser

    User->>ClubApplyButton: Click Apply Button
    ClubApplyButton->>useGetClubDetail: Fetch club detail
    useGetClubDetail-->>ClubApplyButton: Return club detail (with recruitment period, externalApplicationUrl)
    ClubApplyButton->>ClubApplyButton: Parse recruitment period, check if recruiting
    alt Not Recruiting
        ClubApplyButton->>User: alert("모집 마감")
    else Recruiting
        ClubApplyButton->>getApplication: Fetch user's application
        alt Application exists
            getApplication-->>ClubApplyButton: Success
            ClubApplyButton->>Browser: Navigate to application page
        else Application not found
            alt externalApplicationUrl exists
                ClubApplyButton->>Browser: Open external URL in new tab
            else
                ClubApplyButton->>User: alert("모집 정보를 확인해 주세요")
            end
        end
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • #592: ClubApplyButton의 클릭 핸들러 내비게이션 로직 변경 관련 PR로, 본 PR과 동일 컴포넌트의 동작을 다룹니다.
  • #536: ClubApplyButton의 모집 상태 처리 및 지원 내비게이션 관련 초기 기능 PR로, 본 PR과 직접적인 코드 레벨 연관성이 있습니다.
  • #605: ClubApplyButton의 isRecruiting prop 제거 및 내부 모집 상태 비동기 처리 리팩토링 PR로, 본 PR과 동일한 컴포넌트 및 로직을 다룹니다.

Suggested labels

🛠Fix

Suggested reviewers

  • seongwon030
  • lepitaaar
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop-fe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@Zepelown Zepelown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버그 수정 정말 고생 많으셨습니다~

Copy link
Member

@seongwon030 seongwon030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend 📈 release 릴리즈 배포

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments