Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-24570] Drop sorted() from LineageService #190

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Mar 18, 2025

Change Summary

Drop using sorted(...) from LineageService. Instead change annotation for repository methods to accept Collection, which can be list, set, dict keys and so on. Convert them to list only where we actually need to (in ANY(...) SQL expression).

This doesn't increase performance, but reduces noise in source code.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Mar 18, 2025
@dolfinus dolfinus self-assigned this Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (a25bcae) to head (7360e35).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #190   +/-   ##
========================================
  Coverage    91.87%   91.87%           
========================================
  Files          197      197           
  Lines         4872     4876    +4     
  Branches       338      338           
========================================
+ Hits          4476     4480    +4     
  Misses         327      327           
  Partials        69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus marked this pull request as ready for review March 18, 2025 11:50
@dolfinus dolfinus merged commit 34e3c92 into develop Mar 18, 2025
14 checks passed
@dolfinus dolfinus deleted the improvement/DOP-24570-sorted branch March 18, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants